Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yugg Gun to fix issues with gene sting #75079

Merged
merged 30 commits into from
Jul 24, 2024

Conversation

Maleclypse
Copy link
Member

Summary

None

Purpose of change

Fix issues with using a spell for gene sting instead of gun delivering spell.

Describe the solution

reimplements my original work

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves astyled astyled PR, label is assigned by github actions labels Jul 18, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jul 18, 2024
@github-actions github-actions bot added [Python] Code made in Python Code: Tooling Tooling that is not part of the main game but is part of the repo. labels Jul 18, 2024
data/json/species.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Mechanics: Enchantments / Spells Enchantments and spells label Jul 19, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • SCREEE!!!!
  • unch

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

data/json/species.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jul 22, 2024
@github-actions github-actions bot removed the json-styled JSON lint passed, label assigned by github actions label Jul 22, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Jul 22, 2024
@github-actions github-actions bot added the Code: Tests Measurement, self-control, statistics, balancing. label Jul 24, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 24, 2024
@dseguin dseguin merged commit f91e479 into CleverRaven:master Jul 24, 2024
23 of 25 checks passed
@Maleclypse Maleclypse mentioned this pull request Jul 26, 2024
@Maleclypse Maleclypse deleted the Yugg-genesting-gun branch July 26, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Monsters Monsters both friendly and unfriendly. [Python] Code made in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants