Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary damage types #75464

Merged
merged 9 commits into from
Aug 8, 2024
Merged

Remove unnecessary damage types #75464

merged 9 commits into from
Aug 8, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Aug 5, 2024 •
edited
Loading

Summary

None

Purpose of change

I didn't like the approach, picked in #75079
Now i can fix it

Describe the solution

Remove damage types used to run EOC_random_mutate
Move EoC run into ammo effect for yugg sting, and into monster attack for XE mon_mi_go_stalking_warper
Remove unused spells

Testing

Equipped armor, got dozens of shots from jugg, still can mutate when armor is penetrated

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved labels Aug 5, 2024
@github-actions github-actions bot requested a review from Maleclypse August 5, 2024 10:21
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 5, 2024
@github-actions github-actions bot added [Python] Code made in Python Code: Tooling Tooling that is not part of the main game but is part of the repo. labels Aug 5, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 5, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 7, 2024
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 7, 2024
@kevingranade kevingranade merged commit 643bab3 into CleverRaven:master Aug 8, 2024
21 of 27 checks passed
@GuardianDll GuardianDll deleted the jugg_ammo_effect branch August 8, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maleclypse Maleclypse Maleclypse left review comments

Assignees
No one assigned
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tooling Tooling that is not part of the main game but is part of the repo. <Documentation> Design documents, internal info, guides and help. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. [Python] Code made in Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuardianDll @Maleclypse @kevingranade