Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scorched zombie audit #75071

Merged
merged 13 commits into from
Jul 22, 2024
Merged

Scorched zombie audit #75071

merged 13 commits into from
Jul 22, 2024

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Jul 17, 2024

Summary

Content "Scorched zombie audit"

Purpose of change

Our scorched zombies were weird living smoke grenades that for some reason were more armored than zombie cops (in all but bash). I really liked their concept, but hated the execution, and when working with them on my previous zombie PRs it's become apparent they've needed some TLC for a longer while.

Describe the solution

Changes to vanilla scorched and child scorched zombies
  • Removed their natural armor weakpoints, because they're no longer naturally armored
  • Slowed them down
  • Upped the health for the adults, slightly lowered it for the kids
  • Removed the burn care proficiency because there's no way cutting apart a horribly burnt zombie corpse is gonna teach you how to be a first responder
  • Lowered their armor a bunch
  • Removed their weird smoke grenade death spells
  • Gave them low but not 0 bleed rates
  • Lowered the adult's grab strength
  • Slightly changed the adult's description
  • Renamed the child to be more descriptive in what it actually is
  • Normalized their melee to be slightly worse than their not-burnt counterparts
Scorched brute
  • Based on the old fiend, replaced all occurences of old fiend ID with this
  • Slightly weaker but more armored burnt version of a zombie brute
Fiend
  • Complete overhaul to get it from a weird spiky DOOM-flavored brute into a burnt body horror gorilla-hulk
  • Significantly stronger (in theory does more damage than the hulk, but is slower and more flimsy)
  • Made the hulks (excluding the nemesis, as I don't want to touch it in case I break something horribly, unless @RenechCDDA or @PatrikLundell give me the blessing to do so as they're the people I've seen touch the nemesis last) burn into the fiends
Lasher
  • Stat-wise basically the same as a default scorched zombie but slightly slower and worse at melee
  • Doesn't grab and doesn't scratch, but utilizes its arms as whips to bash you from 3 tiles away
  • Produced from batwing and grabber zombie lines
Dogs
  • Pretty much nothing interesting to say, just scorched equivalents of zombie dogs, with a hulking horror equivalent present
  • Baseline gets created from zombie dogs and their mutants, mutant coyotes, dogs, mutant dogs, wolves, zombie wolves
  • Hulking horror equivalent gets created from hulking horrors or dire wolves

MISC

  • Switched "pierces" for "rakes" in the stretch attack's definition, since piercing seems like it'd do more than the attack actually does, and most monsters would probably slash instead of stabbing directly. The exception is the naiad, which already has unique strings and is unaffected.
  • Removed some unused lines from the batwing zombie family that I missed in my previous copy-from PRs. No gameplay effects from this.

Describe alternatives you've considered

The scorched variation of the hulking horror has a placeholder name because I couldn't think of anything better that was descriptive and didn't sound stupid. I initially wanted to go with Hellhound but that sounds cringe as hell

Testing

Additional context

  • This, in general, is a massive nerf for the scorched zombie line. That is okay, as they are supposed to be more damaged variations of other zombies, not something specifically evolved. In future PRs I'd like to add a new zombie line that these guys would specifically evolve into, covered head to toe in scar tissue and actually armored. But that's for the future, because if I did it here the PR would be unreviewable.
  • Lasher's special attack is defined separately instead of inside the monster definition as I intend to reuse it for the callous version of the lasher in a future PR, so I'd rather define the special in that file already than move file contents around later.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Monsters Monsters both friendly and unfriendly. Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods: Sky Island Anything about the Sky Island mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 17, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A monstrous burnt vaguely humanoid creature, walking around on its knuckles like a gorilla. Tattered and blackened strands of muscle fibers dangle all around its body, with patches of fused melded skin and bone visible inbetween. Its forelimbs end in lengthy skeletal claws.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 18, 2024
Copy link
Member

@harakka harakka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the "mended into patches" thing but I don't know how to phrase it better.

data/json/monsters/zed_burned.json Outdated Show resolved Hide resolved
data/json/monsters/zed_burned.json Outdated Show resolved Hide resolved
@Karol1223 Karol1223 marked this pull request as ready for review July 21, 2024 11:11
@Maleclypse
Copy link
Member

Conflicts

@Maleclypse Maleclypse merged commit 9e5b1a1 into CleverRaven:master Jul 22, 2024
24 checks passed
@Karol1223 Karol1223 deleted the scorchy branch July 23, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Sky Island Anything about the Sky Island mod Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants