Migrate NPC rules to a new, dedicated imgui menu #74854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by pressing close button. Also fixed this in mission ui
-Extract the common button setup into a function -Only pop style color when it's been pushed -Export/Import displays warning when only 1 follower -other very minor changes
github-actions
bot
added
NPC / Factions
db48x
changed the title
|
/me sighs I guess I’ll placate clang-tidy too. I need to figure out how to run that locally at some point, so that I’m not surprised by it. |
github-actions
bot
added
the
BasicBuildPassed
clang-tidy was concerned about it so I guess we can use references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "NPC follower rules can now be viewed and modified in a dedicated, mouse-supported window (imgui)"
Purpose of change
Everyone agrees the dialogue menu does its job for this, but it could be so much better...
Describe the solution
Make it better, and with making it better comes mouse support!
There is now a dedicated top-level talk topic which opens this new imgui window, no need to remember which of the sub-menus your specific rule was in. Each rule can be fully adjusted with a dedicated hotkey or mouse-sensitive buttons. For rules with multiple states (e.g. CBM recharge %) keyboard presses of the hotkey will cycle to the next setting, while mouse presses are set directly to the selected % button. Keyboard users also have the option of navigating(standard up/down/left/right inputs) directly to the desired setting and press enter, instantly setting that value without a need to toggle through the proceeding ones.
(Still WIP) Tie the imgui buttons to a specific set of auto-assigned hotkeys, like our dialogue does. This is almost certainly a requirement before this PR can be undrafted.Describe alternatives you've considered
We originally considered toggle buttons, but checkboxes and radio buttons are much cooler.
Closes #74359