Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to set rules for npc Liam #74967

Closed
Little-119 opened this issue Jul 10, 2024 · 1 comment · Fixed by #75045
Closed

Unable to set rules for npc Liam #74967

Little-119 opened this issue Jul 10, 2024 · 1 comment · Fixed by #75045
Labels
(S2 - Confirmed) Bug that's been confirmed to exist

Comments

@Little-119
Copy link

Little-119 commented Jul 10, 2024

Describe the bug

It's not possible to (permanently) set combat commands or rules for Liam, the starting NPC from the Friends to the End scenario.
Random NPCs/the starting NPC in the Evacuee scenario have a new dialog option for opening an imgui menu from #74854 while Liam retains the old dialog options, and attempting to use them results in an error,

 DEBUG    : I don't know what to say for TALK_COMBAT_COMMANDS. (BUG (npctalk.cpp:dynamic_line))

 FUNCTION : std::string dialogue::dynamic_line(const talk_topic&)
 FILE     : src/npctalk.cpp
 LINE     : 1589
 VERSION  : cdda-experimental-2024-07-10-0115 b65512ddf8

(TALK_MISC_RULES for misc rules)
and an empty dialog.

Attach save file

North Salem-trimmed.tar.gz

Steps to reproduce

(create a character in the Friends to the End scenario)
(speak to Liam and advance through his intro dialogue)

  1. Talk to Liam
  2. Choose a: I want to give you some commands for combat. or b: I want to set some miscellaneous rules.

Expected behavior

Receiving the respective rules-setting menu

Screenshots

image
image

Versions and configuration

  • OS: Linux
    • OS Version: Distributor ID: Debian; Description: Debian GNU/Linux 12 (bookworm); Release: 12; Codename: bookworm;
  • Game Version: cdda-experimental-2024-07-10-0115 b65512d [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda],
    Portal Storms Ignore NPCs [personal_portal_storms],
    Slowdown Fungal Growth [no_fungal_growth],
    sees-player, run, crouch, bleed icons, retrodays [sees_player_retro]
    ]

Additional context

Issue is no longer present after reverting 3f6bf65 and compiling

@Little-119 Little-119 added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label Jul 10, 2024
@PatrikLundell
Copy link
Contributor

/Confirmed

@github-actions github-actions bot added (S2 - Confirmed) Bug that's been confirmed to exist and removed (S1 - Need confirmation) Report waiting on confirmation of reproducibility labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants