Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct occlusion distance calc for non-isometric tilesets #74445

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

Procyonae
Copy link
Contributor

@Procyonae Procyonae commented Jun 11, 2024

Summary

None

Purpose of change

Describe the solution

Describe alternatives you've considered

Testing

Used this test map of 3x3 OMTs filled with casings

  {
    "type": "mapgen",
    "method": "json",
    "om_terrain": [ "casings" ],
    "object": { "fill_ter": "t_region_groundcover", "item": { " ": { "item": "4570_casing", "chance": 100 } } }
  },
  {
    "type": "overmap_terrain",
    "id": "casings",
    "name": "nothing",
    "sym": "%",
    "color": "white",
    "flags": [ "NO_ROTATE" ]
  },
  {
    "type": "overmap_special",
    "id": "casings",
    "overmaps": [
      { "point": [ 0, 0, 0 ], "overmap": "casings" },
      { "point": [ 1, 0, 0 ], "overmap": "casings" },
      { "point": [ 2, 0, 0 ], "overmap": "casings" },
      { "point": [ 0, 1, 0 ], "overmap": "casings" },
      { "point": [ 0, 2, 0 ], "overmap": "casings" },
      { "point": [ 1, 1, 0 ], "overmap": "casings" },
      { "point": [ 2, 1, 0 ], "overmap": "casings" },
      { "point": [ 1, 2, 0 ], "overmap": "casings" },
      { "point": [ 2, 2, 0 ], "overmap": "casings" }
    ],
    "locations": [ "field" ],
    "occurrences": [ 0, 8 ]
  }

Max occlusion = 10:
image

Max occlusion = 16:
image

Iso occlusion seems to creep off centre starting at 16 but that's not what I'm here to solve rn

Additional context

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jun 11, 2024
@Procyonae Procyonae marked this pull request as ready for review June 11, 2024 10:16
@Maleclypse Maleclypse merged commit afca258 into CleverRaven:master Jun 11, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants