Corpses will sometimes display the fallback corpse sprite even if they have one properly set for themselves / Monsters alternate between available sprites

[Karol1223]

Describe the bug

If an item starts with corpse_[monster], it will always show its own sprite unless the player is standing on it, or is examining the tile its on with x, at which point it will instead show the sprite of the corpse the ID is similar to

The voices in the comment say it is not limited to monsters. I have not witnessed this, but Guardian is adamant about telling me to edit the issue to mention it so here you go.

Attach save file

N/A

Steps to reproduce

1. Spawn corpse_yugg_jade
2. Look that it has its own symbol
3. Enter x view and examine the tile its on
4. Witness the fallback corpse sprite

Expected behavior

The item should always use the same sprite, not switch depending on how its being looked at

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.0.22631.3880 (23H2)
• Game Version: 0.G-10799-gcaff33e8a8-dirty [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [
  Dark Days Ahead [dda],
  Disable NPC Needs [no_npc_food],
  Portal Storms Ignore NPCs [personal_portal_storms],
  Slowdown Fungal Growth [no_fungal_growth]
  ]

Additional context

No response

[Karol1223]

Changing the title in light of new events - this seems to apply to actual corpse items as well, they will sometimes just randomly decide to use the fallback sprite instead. Examining their tile and standing on them seems to do it reliably, but they sometimes seem to do it at random, too.

[Uwuewsky]

I think the same thing happens not only with items, but also with entity sprites.
On the week old version (build type: linux-tiles-x64, build number: 2024-07-22-0401, commit sha: a1bce17), the fungal zombies also changed their sprite if a player is within one tile, just like corpses.

I updated to the latest (build number: 2024-07-28-2319, commit sha: a334d3d), it seems to me the bug is still there, but the behavior has changed slightly. They now change sprite randomly if the player wanders nearby.

Corpses will change sprite if the player approaches them from the southwest.

[GuardianDll]

[GuardianDll]

Also please edit issue to detail it is not limited by corpses

[inogenous]

Is it possible that this check here should be !is_isometric()? From b33241a . I can no longer reproduce the issue if this check is flipped.

Cataclysm-DDA/src/cata_tiles.cpp

Lines 2503 to 2505 in 8062226

	const float distance = is_isometric() ? o.distance( pos.xy() ) :
	point( static_cast<int>( o.x + ( screentile_width / 2.0f ) ),
	static_cast<int>( o.y - 1 + ( screentile_height / 2.0f ) ) ).distance( pos.xy() );

[GuardianDll]

The place is correct, but i suspect #74445 was the reason of it, which was specifically about using the same feature beyond iso tilesets

[IdleSol]

cdda-windows-tiles-x64-2024-08-26-1250

Same with the corpses of normal zombie