Container audit (mostly transparency) #73458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Balance "Make most plastic and glass containers transparent"
Purpose of change
Working on #73400 revealed that containers are not transparent (apart from two exceptions). The most notable non-transparent containers are a
plastic bag
and aplastic bottle
.Some containers didn't make sense.
tankard_wooden
wasn't an open container, so you could transport coffee in it in your bagcamelbak
, which is a hydration pack was rigidDescribe the solution
I went through all containers in items/containers/containers.json and added
"transparent": true
where it made sense. If it had a URL in "//", I looked at that, if not, I often googled it. If at least half of the pictures were transparent, I made it transparent - my rationale is a benefit of the doubt, the non-transparent container will be more annoying to work with in the future, I think.tankard_wooden
"open_container": true
."rigid": true
fromcamelbak
.Describe alternatives you've considered
Testing
TODO:Rebased #73400 onto this and enjoyed that I can see inside the containers (meaning they don't indicatehides content
, which means they are transparent.)V
iew Item List.NEW!
.paper wrapper
andtin can (sealed)
still hide contentsplastic bottle
,glass bottle
, andplastic bag
don't hide contents.Additional context
bag_plastic_small
is watertight, so you can put water in it, put it on the ground or in a bag and it won't spillI didn't believe the bag would hold liquid, so I took one IRL, filled it with water and it didn't leak! Marvellous!