Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydration Pack Volume Incorrect #73508

Closed
ExplosiveRunes opened this issue May 4, 2024 · 1 comment · Fixed by #73794
Closed

Hydration Pack Volume Incorrect #73508

ExplosiveRunes opened this issue May 4, 2024 · 1 comment · Fixed by #73794
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility

Comments

@ExplosiveRunes
Copy link

Describe the bug

Recently the hydration pack's volume changed from .01 L empty to 3.00 L empty, and expands to 6.00L when full. This prevents it from being placed within pockets specifically designed for it when full, such as the "pouch sized for a hydration pack." on the MOLLE assault pack. The Hydration Pack may not be the only item affected by whatever has changed, but it is the item that I noticed this on.

image
image
image

Attach save file

N/A

Steps to reproduce

  1. Create new world with only Dark Days Ahead content pack
  2. Spawn in Hydration pack
  3. Observe volume when filled an unfilled

Expected behavior

The hydration pack previously had a volume of .01 L empty and would expand to include the volume of the contained liquid up to its maximum.

Screenshots

No response

Versions and configuration

  • OS: Windows
    • OS Version: 10.0.22631.3155 (23H2)
  • Game Version: 00d3e82 [64-bit]
  • Graphics Version: Tiles
  • Game Language: English [en]
  • Mods loaded: [
    Dark Days Ahead [dda]
    ]

Additional context

No response

@ExplosiveRunes ExplosiveRunes added the (S1 - Need confirmation) Report waiting on confirmation of reproducibility label May 4, 2024
@Hyperseeker
Copy link
Contributor

Caused by #73458. Hydration pack used to be 3001 mL in volume, with its rigid bladder holding up to 3000 mL (one millilter less) of liquid.

The fix is simple, but not quite. In real life, neither any of the Camelbak family of hydration bladders nor the MOLLE II hydration bladder (which is relevant because military backpacks in the game have a pocket for it) is only 1 mL in volume. From my calculations for Armory, the MOLLE II bladder is just over 250 mL in volume, empty. This would make a full 3 L bladder (which it is rated for) just over 3250 mL. This could be trimmed down to an actual 3250 mL, for the purpose of the game being nice and even with its values.

Basically, whoever takes up fixing this should just make the hydration pack ~250 mL in volume, and adjust the pockets that it's supposed to sit in (MOLLE packs etc.) accordingly.

(Worth noting that camelbak, the in-game item, is supposed to be two items in one: the bladder which holds the liquids, and the thin sleeve of a backpack that would allow carrying the bladder on their person. Right now, you can carry the bladder on your shoulders like a regular backpack. The MOLLE II carrier – i.e., said backpack – could add anywhere between 500 mL and 1500 mL on its own, depending on the thickness of the nylon.)

TheAthenaCabin0 added a commit to TheAthenaCabin0/Cataclysm-DDA that referenced this issue May 14, 2024
With the change of hydration pack to a non-rigid container, when filled
up to its maximum volume of water, it would expand excessively to 6 L,
as opposed to its approximate 3250 mL maximum volume (as calculated by
@Hyperseeker.
references CleverRaven#73508, references CleverRaven#73458
TheAthenaCabin0 added a commit to TheAthenaCabin0/Cataclysm-DDA that referenced this issue May 14, 2024
With hydration pouches being up to 3.25 L when full, all places where
hydration pouches have dedicated pockets needed to be increased
explicitly from 3.01 L to 3.25 L.
fixes CleverRaven#73508, fixes CleverRaven#73535
TheAthenaCabin0 added a commit to TheAthenaCabin0/Cataclysm-DDA that referenced this issue May 15, 2024
With the change of the hydration pouch to be a non-rigid container, the
size of the pouch when empty will be changed, and will be at full 3250
mL. This is the first step, the changing of the pockets.
references CleverRaven#73508, references CleverRaven#73535
TheAthenaCabin0 added a commit to TheAthenaCabin0/Cataclysm-DDA that referenced this issue May 15, 2024
It will allow hydration pouches to fit in the now 3250 mL hydration
pouch pockets from the previous commit, and it makes the empty (and
full) size of the pouch more accurate to reality.
fixes CleverRaven#73508, fixes CleverRaven#73535
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(S1 - Need confirmation) Report waiting on confirmation of reproducibility
Projects
None yet
2 participants