Expand the Russian name list with translated name snippets before #70279 (Help wanted with reviewing) #73083
Conversation
github-actions
bot
added
[JSON]
|
This file would really benefit from in-line comments of the original names. |
|
@Hyperseeker @Vane79 thanks a lot for the reviews. I'll look into them.
I suppose so. I'll see if I can make that happen, but JSON does not support inline comments so it might take some tinkering with the JSON format. It may also require changes to the C++ code if we wish to keep the comments. |
|
This file would really benefit from not being sorted alphabetically so that it can be opened side-by-side with the original file. And from separating snippet categories into separate files. I'm not sure it's worth adding translations from a .mo file. File are still significantly different from en.json (fewer names, literal translations). I planned to work on this file someday. I recently finished what I wanted, so I can take it right now. I can create a separate PR or I can send PR to |
It would if it only contains translated names from I might be able to generate a file that contains the source English name in the same order as the current
That should be doable, but is outside the scope of this PR.
In some previous version of the game, the names in There is indeed the problem of literal translations for a few of the strings, but from my experience with doing this for the Simplified Chinese file in #73077, only a small part of the strings are affected, so the translations are actually worth salvaging. Eventually these files should be made translatable on Transifex but I'll have to find out if it supports this kind of files that does not have a one-to-one correspondence between strings. (This is needed because many different names in English might have the same transliteration due to the target langauge having a different set of syllables; the translators might also want to add in names from their own languages.)
Please do, and thanks in advance! |
|
I wanted to continue the review today, but since @Uwuewsky is working to make a few changes, I'll hold off until they push theirs. |
…reael07, and Vane79! Co-authored-by: Steve Brand <[email protected]>
… Vane79! Co-authored-by: Steve Brand <[email protected]>
Co-authored-by: Steve Brand <[email protected]>
|
@Hyperseeker I merged the modification by @Uwuewsky, so the format of the file has changed. There's still a line-to-line correspondence between the name lists so the file can be reviewed by opening the English and Russian files side-by-side. |
|
So, I've just looked at the latest changes, and... frankly, I'm lost. There's so much to look through, even my browser is struggling. May I suggest these changes be broken up by category, and split between multiple PRs? City names, first names, nicknames etc. – it would make reviewing them much-easier. |
|
Sure, I'll break this PR up (and probably merge the English and Russian files for easier review). |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered. |
…verRaven#70279 (Help wanted with reviewing) (CleverRaven#73083) * Add Russian names from translated name snippets before CleverRaven#70279 Family and given names from names/en.json are converted to translated names from the Russian mo file before CleverRaven#70279 and added to names/ru.json using a script. * Fix some incorrectly translated Russian names, thanks Hyperseeker, Zireael07, and Vane79! Co-authored-by: Steve Brand <[email protected]> * Fix more incorrectly translated Russian names * Fix more incorrectly translated Russian names, thanks Hyperseeker and Vane79! Co-authored-by: Steve Brand <[email protected]> * Update ru.json * Fix more incorrectly translated Russian names Co-authored-by: Steve Brand <[email protected]> --------- Co-authored-by: Steve Brand <[email protected]> Co-authored-by: Uwuewsky <[email protected]>
|
Hey, just FYI, this wasn't finished. I was waiting for @Qrox to break down the names for easier reviewing and merging. There's still a lot of names to review in this PR. |
@Uwuewsky had said in discord that they had fully reviewed this and it was ready for merge once it was reopened. Let me know if you want me to link to that comment in the devcord. |
|
I disagree, but if the author of the PR can't or doesn't want to split the PR for further review, who am I to argue? My goal was to help, and to the best of my ability, I've helped. |
|
Sorry, I have been occupied with other IRL things so I wasn't able to finish breaking up this PR. Your help so far is much appreciated. In any case, the updated Russian names should have a one-to-one correspondence with the English names, so the file can still be reviewed piece by piece if anyone's interested. |
|
That's okay, I'm not blaming you for anything. It's just that you seem to be the only one so far to take up the effort, which too is much appreciated. :) |
Summary
I18N "Expand the Russian name list with translated English names"
Purpose of change
Similar to #73077, add Russian translation of the name snippets from before #70279 to the Russian name file.
Describe the solution
Family and given names from
names/en.jsonare converted to translated names from the Russian mo file before #70279, and added tonames/ru.json, using the script in #73083 (comment).Still a draft because I don't understand Russian and need help reviewing the changes.
Describe alternatives you've considered
Testing
Just regular JSON changes, should be fine if the CI tests pass.
Additional context
I know very little Russian so I'd appreciate some help with reviewing the generated lists. If you would like to help, please go through the lists and mark strings that are not names for removal.