Add more English names and their translations to Simplified Chinese and Japanese #73077
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I18N "Add more English names and their translations to Simplified Chinese and Japanese"
Purpose of change
In #70279 some name snippets were removed without being added to
data/names
. Also, the current Simplified Chinese and Japanese name lists only contain very few entries.Describe the solution
Merge the removed names with the list in
data/names/en.json
. Salvage the names translated before #70279.First, the removed names from #70279 are appended to the corresponding lists in
names/en.json
, sorted, and made unique. The given names from MoM are not added, because they lack gender information required by the lists.Then the family and given names from
names/en.json
are converted to translated names using the following script..po
files from the merge commit f255964 of #70279 are used to generate the.mo
files before running the script.The script I used to generate the list of translated names
For the Japanese names, the generated translated names are appended to the corresponding lists in
names/ja.json
, sorted, and made unique. Translations that are not names are then removed (they are easy to locate after sorting, because the Japanese translators translated the names using half-width katakana exclusively).For the Simplified Chinese names, the generated translated names are appended to the corresponding lists in
names/zh_CN.json
, sorted, and made unique. I then skimmed through the lists and removed translations that are not names.Describe alternatives you've considered
Make all names Tom.
I decided to not split up this PR into smaller ones because the changes can be easily verified by following the above steps.
Testing
Just regular JSON changes, should be fine if the CI tests pass.
Additional context
I need help with adding the Russian translations, because some English names were translated to their literal meaning instead of names. It should be as simple as going through the list of changes and remove any strings that are not real names, so if someone would like to help please see #73083. The changes have
2775 insertions(+), 950 deletions(-)
so it should take around 1 hour of reviewing.Other languages seem to have very few translated names as of #70279 so they are not included in this PR.