Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hunt down the freezer #73048

Merged
merged 8 commits into from
Apr 21, 2024
Merged

Hunt down the freezer #73048

merged 8 commits into from
Apr 21, 2024

Conversation

GuardianDll
Copy link
Member

@GuardianDll GuardianDll commented Apr 15, 2024

Summary

Content "Fridges and freezers. What do you mean 'we already have some'?"

Purpose of change

I want

Describe the solution

Add a variety of new fridges and freezers, and update the stats of the old one:

  • fridge - default one we've already have before; 42 W, 311L
  • minifridge - yknow; 45 W, 96 L, can be put in vehicle
  • food truck fridge - chonky boy, but still can fit in the car; 51 W, 250 L, can be put in vehicle
  • single glass door fridge - one used in grocery store for drinks; 141 W, 347 L
  • double glass door fridge - same as previous one, but bigger; 360 W, 991 L
  • heavy-duty fridge - very chonky boy; 60 W, 700 L
  • display fridge - also popular choice in grocery store; 205 W, 600 L

 

  • freezer - like the old one; 45 W, 122 L
  • minifreezer - good old one; 46 W, 90 L, can be put in vehicle
  • chest minifreezer - like the old one, but better; 26 W, 99 L, can be put in vehicle
  • food truck freezer - bigger, but vehicle compatible; 211 W, 250 L, can be put in vehicle
  • chest freezer - can't be more efficient than this; 36 W, 350 L
  • heavy-duty freezer - best for your kitchen, if you're a chef; 576 W, 745 L
  • glass door freezer - usually present some fancy pizza boxes in groceries, now present piles of butchered mutant meat; 456 W, 400 L
  • display freezer - like chest one, but with glass lid; 27 W, 320 L

 

now fridge can be disassembled into household fridge and freezer at once (sad problem that the game do not allow them to be a single unit, as it often happens in industry)

TODO:

  • Fix disassembly and vehicle destroying drop
  • Replace some vehicle fridges and freezers in vehicle json with new one

Testing

Run for a while in the world, smashed different fridges, used some as appliance. seems good for me

Followup

Decided to split the PR in two, since this one is already too big. Second part would contain mapgen changes to put new fridges on the map, and maybe, if i'll get a green light, adding fridges to the scrap trader

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Vehicles Vehicles, parts, mechanics & interactions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Appliance/Power Grid Anything to do with appliances and power grid labels Apr 15, 2024
@GuardianDll GuardianDll marked this pull request as draft April 15, 2024 20:46
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Apr 15, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A compact version of a chest freezer, designed as a mobile solution for freezing food. Perfect choise to put in your closet and forget for a year, but it's pretty tricky to pull anything digged with frozen perishables. Activate to deploy and connect to your electric grid.
  • A compact version of an upright freezer, designed as a mobile solution for freezing food. Perfect choise for your drinks at hot summer. Activate to deploy and connect to your electric grid.
  • A disconnected household freezer. Great choise if you need to freeze some discount meat. Activate to deploy and connect to your electric grid.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@KHeket
Copy link
Contributor

KHeket commented Apr 16, 2024

How did you get such big energy consumption values? Because when I tried to make it logically close by calculations - I was raped and forced to check real world analogies
#65857
And I also read some info
For example, if I understand you correctly with heavy-duty freezer - it big chest freezer, and more insulation you add - less energy it will consume 30-60-90W, but not 200-300-500+

Spoiler

image

Even if the heavy-duty freezer will fast freeze or freeze for very low temperature - it will not consume such lot power if you don't let its door open and make all cold air to go out
Because 576W = 5045 kWh per annum used , what is 5 megawatt
(576W * 24 hours a day * 365 days = 5045 kWh per annum used)

@GuardianDll
Copy link
Member Author

How did you get such big energy consumption values

I checked the annual/daily power consumption, that manufacturer provided, and calculated it to hourly consumption (if annual, then x/8760 hours in year, if daily, then x/24 hours in day), then multiplied it on 1.2 for chest versions, and 1.5 for upright version.

Numbers are up to debate, especially if someone find how the manufacturer test their fridges and how much it is a spherical cow (because without this information i assume the number they provide is the worst case - extrapolation of some internal test, where they plug fridge and never open it for x amount of time, which is far from how survivor will use it), but i assume they are good enough

@KHeket
Copy link
Contributor

KHeket commented Apr 16, 2024

that manufacturer provided

Can you give a link to manufacturer characteristics? Because so big energy consumption looks like a mistake

@GuardianDll
Copy link
Member Author

GuardianDll commented Apr 16, 2024

each item has a comment with a name of actual fridge/freezer (or a direct link), from which stats are delivered from.

In case of heavy-duty freezer, it's Infrico AGN602BT, https://infricodocuments.com/infrico/spec_sheet/es/AGN602BT.pdf took from their web page mention 9,22 kwh/day, which bring us to 384 W mentioned in the comment; multiplying by 1.5 bring us to 576 W

It is something i brought up in discord, because the difference is surprisingly big, comparing it to some another upright freezers, and the conclusion was that two door versions, albeit bigger, do not seal the gaps as good as a single door variants

@KHeket
Copy link
Contributor

KHeket commented Apr 16, 2024

9,22 kwh/day

It should be the value, if the freezer work non stop all day long at the maximum power to maintain the lowest (-18 C° listed in link) of possible temperature
But freezers and fridges don't work that way, they will cool air and then will stop cooling for some time, so in reality there should be lower

This logic can be simply proofed by searching in google "how much kWh per annum will freezer consume"
https://www.appliancecity.co.uk/refrigeration/freezers/how-much-energy-does-my-freezer-use/

Spoiler

image
image

So multiplication should be in opposite way
384 > 256
And I am not sure, that decreasing by 1.5 times is truly right, because real watts consumption can be lesser than 1.5 decrease
Its very rude way to calculate +- close to reality energy consumption, but if we don't have proofs with power usage monitor plug tests - I don't know another way to calculate correct values

@GuardianDll
Copy link
Member Author

GuardianDll commented Apr 16, 2024

Well, it's completely opposite approach from mine - you assume that manufacturer write the power output based on the "we left our freezer completely open for a day, and extrapolate it on a year basis", when mine is "we left out freezer completely closed for a day, and extrapolate it on a year basis".

While i don't know which method is used to obtain the number (nor do you), i will stand my ground, because in my opinion advertisement department is more interested in showing the product better than it is, rather than quality department showing it is not

upd: reading 2015/1094-1, it doesn't specify a need for the manufacture to open unit or enforce it's maximum output for all time, and the formula for power output of heavy-duty fridge is, you guess it, power consumption in 24 h × 365

upd2: adressing your link, it uses not the hourly power output to calculate power, but the max power the fridge can use
if we use the value, provided by the manufacturer in the document i posted recently (which is 1112 W), and make what your page suggest, divide it by three, we would get 370 W - which is pretty close to 384 W we've obtained from annual consumption

@KHeket
Copy link
Contributor

KHeket commented Apr 16, 2024

advertisement department is more interested in showing the product better than it is, rather than quality department showing it is not

When you are talking about fridge/freezer characteristics - in every country there is a law, which forces companies to show true characteristics, no matter what advertisement department are interested in
But if you think, that its right decision to add freezers, which will consume x 16 more power and have only x 2 more capacity, than chest freezer, without proper proofs of real energy consumption - okay, because I am not freezer master and don't know more, than you

But in this way I don't see the reason to use it, because it will burn all your energy. You will need incredible number of solar panels to make it work, or have few cars to generate electricity and burn lots of fuel to make it works

@GuardianDll
Copy link
Member Author

i like how you answered the

advertisement department is more interested in showing the product better than it is, rather than quality department showing it is not

but omitted

upd: reading 2015/1094-1, it doesn't specify a need for the manufacture to open unit or enforce it's maximum output for all time

to clarify, 2015/1094-1 is Commission Delegated Regulation (EU) 2015/1094 of 5 May 2015 supplementing Directive 2010/30/EU of the European Parliament and of the Council with regard to the energy labelling of professional refrigerated storage cabinets, exactly "a law, which forces companies to show true characteristics", and most fridges that i searched are also sold in europe, hence they have the information provided
and it doesn't say anything about testing it any extensively

in fairness, US do not obey it, but it has it's own ftc.gov/energy lable, that has the same function

and about "I don't see the reason to use it, because it will burn all your energy", well. Yes. Don't use it.
THE BIGGEST, THE BULKIEST, THE MOST EXPENSIVE doesn't also mean the most power efficient, the most power efficient is still a generic chest freezers, that one are real deal, another one are more fluff than something experienced player would target

GuardianDll and others added 2 commits April 20, 2024 14:40
… from GIZ GmbH `Guideline on the Manual Dismantling of Refrigerators and Air Conditioners`
@github-actions github-actions bot added the Spawn Creatures, items, vehicles, locations appearing on map label Apr 20, 2024
@GuardianDll GuardianDll marked this pull request as ready for review April 21, 2024 10:39
@GuardianDll
Copy link
Member Author

GuardianDll commented Apr 21, 2024

Now to fix the test errors, and it would be okay to merge, mapgen changes would be in a followup

@github-actions github-actions bot added the Mods Issues related to mods or modding label Apr 21, 2024
@github-actions github-actions bot added the Mods: Aftershock Anything to do with the Aftershock mod label Apr 21, 2024
@github-actions github-actions bot requested a review from Maleclypse April 21, 2024 11:01
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 21, 2024
@Maleclypse Maleclypse merged commit b68f458 into CleverRaven:master Apr 21, 2024
20 of 24 checks passed
@GuardianDll GuardianDll deleted the fridges branch April 21, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants