Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put new fridges on the maps #73250

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

#73048 added lot of refrigeration stuff. this pr adds them on locations

Describe the solution

Make new furniture, for said fridges and freezers
Add this furniture on the maps
fix display fridge dropping heavy duty fridge drop when destroyed
change migration of old freezer from household freezer to chest freezer

I accidentally comitted scrap trader selling the fridges, dunno how silly it is, if it's not desired, i'll remove it

Testing

Game loads, furniture spawns, mapgen mapgennin'

Additional context

I updated only maps with fridges, glass fridges and freezers are omitted because my brain is melting already
some omitted stuff that should be updated: aircraft carrier, hotel tower, commercial_restaurant_palette

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Vehicles Vehicles, parts, mechanics & interactions Spawn Creatures, items, vehicles, locations appearing on map Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions labels Apr 24, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Commercial freezer, used to show ice creams, frozen veggies and pizza in grocery store, while conviniently preserving them. Activate to deploy and connect to your electric grid.
  • Small fridge, oftenly used in places where full-size fridge would be out of place, or to store cold drinks. Activate to connect it to the power grid.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Apr 24, 2024
GuardianDll and others added 2 commits April 25, 2024 08:21
@github-actions github-actions bot added Mods Issues related to mods or modding Mods: No Hope Relating to the mod No Hope labels Apr 25, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-requesting reviews from non-collaborators: @Night-Pryanik

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Apr 25, 2024
@Maleclypse Maleclypse merged commit b658cfa into CleverRaven:master Apr 26, 2024
19 of 24 checks passed
@GuardianDll GuardianDll deleted the fridge_maps branch April 26, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Appliance/Power Grid Anything to do with appliances and power grid astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: No Hope Relating to the mod No Hope Mods Issues related to mods or modding Spawn Creatures, items, vehicles, locations appearing on map Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants