Fixing issue where imgui screens freeze when window is made small #72501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ens stop being drawn.
github-actions
bot
added
[C++]
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
astyled
This was referenced Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixing issue where ImGui screens stop drawing themselves when CDDA window is made small"
Purpose of change
Fixes: #72470
Describe the solution
in input_manager::get_input_event(), forcibly set needupdate to true when an imgui window is on screen so refresh_update() is called
Describe alternatives you've considered
no reason to ever stop drawing the screen completely, we could probably just have some catch-all code to update the screen 30 times a second (at least)
Testing
opened imgui keybindings screen, shrunk screen down to minimum size and verified that the screen still accepts input.
Additional context