Fixing screen artifacts seen when ImGui keybindings UI is closed #72833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
Info / User Interface
|
I don't feel like I really understand what I'm looking at but it doesn't look too likely to break anything. |
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Fixing screen artifacts left on the screen after closing keybindings UI"
Purpose of change
Fixes: #72065
Reverts: #72501
Describe the solution
Reverted a previous change related to forcing the screen to refresh while an ImGui UI is on the screen. the issue was that the UI window dimensions were wrong according to the ui_adaptor which caused confusion as to when certain parts of the screen should redraw.
Describe alternatives you've considered
Testing
Shrink CDDA screen down to, like, 640x480, open the keybindings screen, verify that the UI still redraws properly (responds to input), then close and verify there are no artifacts.
Additional context