Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port some mutation/cbm specific fields to enchantments, part 2 #72106

Merged
merged 25 commits into from
Mar 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
3296d00
remove stealth_modifier
GuardianDll Mar 1, 2024
b99b610
remove attackcost_modifier
GuardianDll Mar 1, 2024
837f4f2
remove pain_modifier
GuardianDll Mar 1, 2024
461c1f7
remove metabolism_modifier
GuardianDll Mar 1, 2024
9b28e9c
remove thirst_modifier
GuardianDll Mar 1, 2024
c21d23c
remove SLOWS_THIRST flag
GuardianDll Mar 1, 2024
d0ec254
remove obtain_cost_multiplier
GuardianDll Mar 1, 2024
786cb5c
remove stomach_size_multiplier
GuardianDll Mar 1, 2024
aa4a207
remove cardio_multiplier, create CARDIO_MULTIPLIER as replacement
GuardianDll Mar 1, 2024
509d6b9
remove weight_capacity_bonus and weight_capacity_modifier
GuardianDll Mar 1, 2024
59600a7
Merge branch 'master' into enchantments_2
GuardianDll Mar 1, 2024
6f52ec5
Apply suggestions from code review
GuardianDll Mar 1, 2024
cb3e927
fix few mistakes
GuardianDll Mar 1, 2024
af40f51
reorder bionic_data struct as clang tidy suggests
GuardianDll Mar 2, 2024
5b4b553
satisfy clang tidy
GuardianDll Mar 2, 2024
9ed5fdd
Update src/character.cpp
GuardianDll Mar 2, 2024
79f35a0
Merge branch 'CleverRaven:master' into enchantments_2
GuardianDll Mar 3, 2024
f513eca
Merge branch 'CleverRaven:master' into enchantments_2
GuardianDll Mar 3, 2024
5d7569d
Merge branch 'CleverRaven:master' into enchantments_2
GuardianDll Mar 4, 2024
224a05a
Merge branch 'master' into enchantments_2
GuardianDll Mar 5, 2024
84318df
fixing conflict wtf
GuardianDll Mar 5, 2024
4986470
cleaning up
GuardianDll Mar 5, 2024
c5c8503
Merge branch 'CleverRaven:master' into enchantments_2
GuardianDll Mar 5, 2024
e45bd5c
Merge branch 'CleverRaven:master' into enchantments_2
GuardianDll Mar 6, 2024
1b06cc5
Merge branch 'CleverRaven:master' into enchantments_2
GuardianDll Mar 7, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/json/bionics.json
Original file line number Diff line number Diff line change
Expand Up @@ -1793,7 +1793,7 @@
"name": { "str": "Titanium Skeletal Bracing" },
"description": "Titanium bracing has been installed onto your elbows, knees, and spine, making them far better at handling strain. Your carrying capacity is increased by 20 kilograms, or about 44 pounds, and you receive slightly less bashing damage to your arms, legs and torso.",
"occupied_bodyparts": [ [ "torso", 8 ], [ "arm_l", 3 ], [ "arm_r", 3 ], [ "leg_l", 3 ], [ "leg_r", 3 ] ],
"weight_capacity_bonus": "20 kg",
"enchantments": [ { "values": [ { "value": "CARRY_WEIGHT", "add": 20000 } ] } ],
"flags": [ "BIONIC_NPC_USABLE", "BIONIC_SHOCKPROOF" ],
"protec": [
[ "torso", { "bash": 2 } ],
Expand Down
5 changes: 0 additions & 5 deletions data/json/flags.json
Original file line number Diff line number Diff line change
Expand Up @@ -915,11 +915,6 @@
"type": "json_flag",
"info": "This clothing is restrictive and <bad>slows your movement speed</bad>."
},
{
"id": "SLOWS_THIRST",
"type": "json_flag",
"info": "This clothing <good>slows your thirst</good> by reducing moisture loss."
},
{
"id": "STURDY",
"type": "json_flag",
Expand Down
3 changes: 2 additions & 1 deletion data/json/items/armor/suits_protection.json
Original file line number Diff line number Diff line change
Expand Up @@ -3090,7 +3090,8 @@
"color": "dark_gray",
"warmth": 15,
"material_thickness": 1,
"flags": [ "VARSIZE", "SKINTIGHT", "HOOD", "WATERPROOF", "SLOWS_THIRST", "SLOWS_MOVEMENT" ],
"flags": [ "VARSIZE", "SKINTIGHT", "HOOD", "WATERPROOF", "SLOWS_MOVEMENT", "MUNDANE" ],
"relic_data": { "passive_effects": [ { "has": "WORN", "values": [ { "value": "THIRST", "multiply": -0.3 } ] } ] },
"armor": [ { "encumbrance": 18, "coverage": 95, "covers": [ "foot_l", "foot_r", "leg_l", "leg_r", "torso", "arm_l", "arm_r" ] } ]
},
{
Expand Down
10 changes: 6 additions & 4 deletions data/json/items/tool_armor.json
Original file line number Diff line number Diff line change
Expand Up @@ -3856,7 +3856,9 @@
"charges_per_use": 1,
"use_action": { "type": "transform", "msg": "The %s engages.", "target": "utility_exoskeleton_on", "active": true },
"flags": [ "STURDY", "OVERSIZE", "BELTED", "WATER_FRIENDLY", "SLOWS_MOVEMENT", "ELECTRONIC" ],
"relic_data": { "passive_effects": [ { "id": "ench_exo_strength" } ] },
"relic_data": {
"passive_effects": [ { "id": "ench_exo_strength" }, { "condition": "ACTIVE", "values": [ { "value": "CARRY_WEIGHT", "add": 215000 } ] } ]
},
"armor": [
{
"encumbrance": 20,
Expand All @@ -3878,7 +3880,6 @@
"power_draw": "972216 mW",
"//": "Battery should last two hours (02:00:07). Weight capacity bonus should include weight of item AND battery, plus 90kg.",
"revert_to": "utility_exoskeleton_off",
"weight_capacity_bonus": "215 kg",
"use_action": { "type": "transform", "menu_text": "Turn off", "msg": "The %s disengages.", "target": "utility_exoskeleton_off" }
},
{
Expand All @@ -3904,7 +3905,9 @@
"charges_per_use": 1,
"use_action": { "type": "transform", "msg": "The %s engages.", "target": "ice_utility_exoskeleton_on", "active": true },
"flags": [ "STURDY", "OVERSIZE", "BELTED", "WATER_FRIENDLY", "SLOWS_MOVEMENT", "ELECTRONIC" ],
"relic_data": { "passive_effects": [ { "id": "ench_exo_strength" } ] },
"relic_data": {
"passive_effects": [ { "id": "ench_exo_strength" }, { "condition": "ACTIVE", "values": [ { "value": "CARRY_WEIGHT", "add": 190000 } ] } ]
},
"armor": [
{
"encumbrance": 20,
Expand All @@ -3925,7 +3928,6 @@
"turns_per_charge": 1,
"//": "Full tank lasts a bit under three hours (166.66 minutes). Has less carry bonus than the battery one since the weight of the fuel will drop over time.",
"revert_to": "ice_utility_exoskeleton_off",
"weight_capacity_bonus": "190 kg",
"use_action": { "type": "transform", "menu_text": "Turn off", "msg": "The %s disengages.", "target": "ice_utility_exoskeleton_off" }
}
]
20 changes: 14 additions & 6 deletions data/json/mutations/cybernetic_traits.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@
"types": [ "Cyberframe", "Cybernetic" ],
"enchantments": [
{
"values": [ { "value": "MAX_HP", "add": 20 }, { "value": "STRENGTH", "add": 4 }, { "value": "DEXTERITY", "add": 4 } ]
"values": [
{ "value": "MAX_HP", "add": 20 },
{ "value": "STRENGTH", "add": 4 },
{ "value": "DEXTERITY", "add": 4 },
{ "value": "CARRY_WEIGHT", "multiply": 2 }
]
}
],
"restricts_gear": [ "torso", "leg_l", "leg_r", "arm_l", "arm_r", "hand_l", "hand_r", "head", "foot_l", "foot_r" ],
Expand All @@ -46,8 +51,7 @@
"acid": 25,
"electric": 5
}
],
"weight_capacity_modifier": 3
]
},
{
"type": "mutation",
Expand All @@ -64,7 +68,12 @@
"types": [ "Cyberframe", "Cybernetic" ],
"enchantments": [
{
"values": [ { "value": "MAX_HP", "add": 10 }, { "value": "STRENGTH", "add": 4 }, { "value": "DEXTERITY", "add": 4 } ]
"values": [
{ "value": "MAX_HP", "add": 10 },
{ "value": "STRENGTH", "add": 4 },
{ "value": "DEXTERITY", "add": 4 },
{ "value": "CARRY_WEIGHT", "multiply": 2 }
]
}
],
"restricts_gear": [ "torso", "leg_l", "leg_r", "arm_l", "arm_r", "hand_l", "hand_r", "head", "foot_l", "foot_r" ],
Expand All @@ -78,7 +87,6 @@
"acid": 25,
"electric": 0
}
],
"weight_capacity_modifier": 3
]
}
]
2 changes: 1 addition & 1 deletion data/json/mutations/mutation_item_traits.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
"valid": false,
"purifiable": false,
"types": [ "Equipment" ],
"weight_capacity_modifier": 1.1
"enchantments": [ { "values": [ { "value": "CARRY_WEIGHT", "multiply": 0.1 } ] } ]
}
]
Loading
Loading