Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Xedra Evolved ] Make Level 5 Alchemy recipes #69278

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Maleclypse
Copy link
Member

Summary

Mods "XE Level 5 Alchemy recipes"

Purpose of change

Make the level 5 alchemy items creatable.

Describe the solution

Adds recipes and things to get those items needed for recipes

Describe alternatives you've considered

Testing

tbd

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Mods: Xedra Evolved Anything to do with Xedra Evolved astyled astyled PR, label is assigned by github actions labels Nov 11, 2023
"intensity": 1,
"body_part": "head",
"immune_inside_vehicle": true,
"message": "You're vision shakes as the air warbles!",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless it's intended to be "You are vision", this "You're vision" should be "Your vision" instead

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Dec 12, 2023
@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Dec 12, 2023
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jan 11, 2024
@Maleclypse Maleclypse removed the stale Closed for lack of activity, but still valid. label Jan 19, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Feb 19, 2024
@Maleclypse Maleclypse removed the stale Closed for lack of activity, but still valid. label Feb 29, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Mar 30, 2024
@Maleclypse Maleclypse removed the stale Closed for lack of activity, but still valid. label Apr 25, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@github-actions github-actions bot added the stale Closed for lack of activity, but still valid. label Jun 6, 2024
@github-actions github-actions bot removed the stale Closed for lack of activity, but still valid. label Jul 4, 2024
@OromisElf OromisElf mentioned this pull request Aug 15, 2024
@Maleclypse Maleclypse marked this pull request as ready for review August 17, 2024 05:49
@github-actions github-actions bot added the Map / Mapgen Overmap, Mapgen, Map extras, Map display label Aug 17, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Comment on lines +145 to +147
"intensity_levels":
[
{ "name": "ginseng_scream",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
"intensity_levels":
[
{ "name": "ginseng_scream",
"intensity_levels": [
{
"name": "ginseng_scream",

[
{ "name": "ginseng_scream",
"sym": "^",
"color": "brown",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
"color": "brown",
"color": "brown",

Comment on lines +152 to +153
"effects":
[
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
"effects":
[
"effects": [

{
"effect_id": "warbled",
"min_duration": "1 minutes",
"max_duration": "72 hours",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
"max_duration": "72 hours",
"max_duration": "72 hours",

Comment on lines +164 to +166
"immunity_data": {
"flags": [ "DEAF" ]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
"immunity_data": {
"flags": [ "DEAF" ]
}
"immunity_data": { "flags": [ "DEAF" ] }

}
],
"half_life": "3 minutes",
"percent_spread": 90,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
"percent_spread": 90,
"percent_spread": 90,

@@ -73,6 +73,55 @@
"flags": [ "ERASE_ALL_BEFORE_PLACING_TERRAIN" ],
"furniture": { "x": "f_golden_monolith" }
}
},
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
{
{

"flags": [ "ERASE_ALL_BEFORE_PLACING_TERRAIN" ],
"terrain": { " ": "t_region_groundcover_forest" },
"furniture": { "x": "f_elder_ginseng" },
"place_monster": [ { "monster": "mon_ginseng_protector", "x": [ 0, 23 ], "y": [ 0, 23 ], "density": 0.3 } ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[JSON & C++ formatters] reported by reviewdog 🐶

Suggested change
"place_monster": [ { "monster": "mon_ginseng_protector", "x": [ 0, 23 ], "y": [ 0, 23 ], "density": 0.3 } ]
"place_monster": [ { "monster": "mon_ginseng_protector", "x": [ 0, 23 ], "y": [ 0, 23 ], "density": 0.3 } ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
Development

Successfully merging this pull request may close these issues.

2 participants