Skip to content

Add optional message to display when choosing map point #82149

Add optional message to display when choosing map point

Add optional message to display when choosing map point #82149

Triggered via pull request November 3, 2024 22:45
Status Failure
Total duration 2h 43m 19s
Artifacts

clang-tidy.yml

on: pull_request
skip-duplicates
6s
skip-duplicates
Matrix: build
Fit to window
Zoom out
Zoom in

Annotations

7 errors
build (src): src/faction_camp.cpp#L289
parameter 'message' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls,-warnings-as-errors]
build (src): src/faction_camp.cpp#L4988
the const qualified parameter 'message' is copied for each invocation; consider making it a reference [performance-unnecessary-value-param,-warnings-as-errors]
build (src): src/faction_camp.cpp#L5011
insufficient spaces at this location. 2 required, but only 1 found. [cata-text-style,-warnings-as-errors]
build (src): src/overmap_ui.cpp#L2505
parameter 'message' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors]
build (src): src/overmap_ui.cpp#L2512
parameter 'message' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors]
build (src): src/overmap_ui.cpp#L2522
parameter 'message' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param,-warnings-as-errors]
build (src)
Process completed with exit code 123.