Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional message to display when choosing map point #77569

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

sparr
Copy link
Member

@sparr sparr commented Nov 3, 2024

Summary

Interface "Replace popups with informative message when choosing point(s) on the map"

Purpose of change

Currently many operations that ask the player to choose one or more points on the map either have one or more popups before/between map views, or provide no feedback at all for the purpose of the choice.

Describe the solution

Made om_target_tile and choose_point optionally show a message to the user while choosing, replaced most relevant popups with this functionality, added messages to some other cases, and moved part of one verbose popup's contents to a mission description.

Describe alternatives you've considered

Testing

I've been playing with a superset of this change for a week now.

Additional context

This is the second in a series of PRs being broken out from #77397

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` Player Faction Base / Camp All about the player faction base/camp/site astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 3, 2024
@sparr sparr force-pushed the map_interface_message branch from 6bfca03 to 77fbfc2 Compare November 4, 2024 02:39
@Maleclypse Maleclypse merged commit 48775fb into CleverRaven:master Nov 5, 2024
20 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display Player Faction Base / Camp All about the player faction base/camp/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants