Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new Definition to upload firmware images greater than 2GB in size #243

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Added a new Definition to upload firmware images greater than 2GB in size #243

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
77937a0
Update ucsgenutils.py
aapatwa Feb 28, 2024
c138e33
Update ucssession.py
aapatwa Feb 28, 2024
db31fe6
Update ucsmsdk/ucsgenutils.py
aapatwa Feb 28, 2024
51eca29
Update ucsgenutils.py
aapatwa Mar 1, 2024
d056cb6
Update ucsguilaunch.py - changed ucsm_launch_url
aapatwa Mar 8, 2024
a9ce0eb
Reverting ucsguilaunch.py
aapatwa Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ucsmsdk/utils/ucsguilaunch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def ucs_gui_launch(handle, need_url=False):

jnlp_file = None
try:
ucsm_gui_url = "%s/ucsm/ucsm.jnlp" % handle.uri
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this change related to this PR or firmware upload in general?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an another issue -
#241
https://jira-eng-sjc11.cisco.com/jira/browse/UCSES-27 (Please refer attachment)

Does it required to create a new Fork and raise PR ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can create new branches in your fork for each bug fix and submit individual PRs from each of your bug fix branches. Do not mix multiple unrelated changes in a single PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure,

ucsm_gui_url = "%s/app/ucsm/index.html" % handle.uri
if handle:
auth_token = handle.get_auth_token()
log.debug("AuthToken: <%s>" % auth_token)
Expand Down