Added a new Definition to upload firmware images greater than 2GB in size #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding new definitions to read a file in chunks , creating URI and to upload firmware
Adding a new definition to upload firmware for file size greater than 2 GB
vvb
requested changes
Feb 28, 2024
Co-authored-by: Vikrant Balyan <[email protected]>
vvb
approved these changes
Mar 1, 2024
vvb
reviewed
Mar 8, 2024
ucsmsdk/utils/ucsguilaunch.py
Outdated
| @@ -56,7 +56,7 @@ def ucs_gui_launch(handle, need_url=False): | |||
|
|
|||
| jnlp_file = None | |||
| try: | |||
| ucsm_gui_url = "%s/ucsm/ucsm.jnlp" % handle.uri | |||
There was a problem hiding this comment.
How is this change related to this PR or firmware upload in general?
There was a problem hiding this comment.
This is an another issue -
#241
https://jira-eng-sjc11.cisco.com/jira/browse/UCSES-27 (Please refer attachment)
Does it required to create a new Fork and raise PR ?
There was a problem hiding this comment.
You can create new branches in your fork for each bug fix and submit individual PRs from each of your bug fix branches. Do not mix multiple unrelated changes in a single PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new definition to read the file in chunks, to create chunks URI and to upload firmware