Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added append_update_ops_data to handle the latest ndo module update operations (DCNE-245) #569

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Added append_update_ops_data to handle the latest ndo module update operations (DCNE-245) #569

merged 6 commits into from
Dec 4, 2024

Conversation

sajagana
Copy link
Collaborator

Note:

Used the same function to test the code with this PR: #563

@sajagana sajagana added the jira-sync Sync this issue to Jira label Nov 15, 2024
@github-actions github-actions bot changed the title Added append_update_ops_data to handle the latest ndo module update operations Added append_update_ops_data to handle the latest ndo module update operations (DCNE-245) Nov 15, 2024
@sajagana sajagana self-assigned this Nov 15, 2024
akinross
akinross requested changes Nov 18, 2024
View reviewed changes
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
plugins/module_utils/utils.py Show resolved Hide resolved
This was referenced Nov 19, 2024
Open
Merged
samiib
samiib requested changes Nov 21, 2024
View reviewed changes
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
@sajagana sajagana requested review from samiib and akinross November 21, 2024 02:58
gmicol
gmicol requested changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from throwing a few extra errors in specific cases, the overall structure of the function looks good to me

plugins/module_utils/utils.py Outdated Show resolved Hide resolved
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
@sajagana sajagana force-pushed the append_update_ops_data branch from c5adf84 to bb18a64 Compare November 28, 2024 14:45
@sajagana sajagana requested a review from gmicol November 28, 2024 14:52
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 9.52381% with 19 lines in your changes missing coverage. Please review.

Project coverage is 72.34%. Comparing base (fb1aa9e) to head (bb18a64).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
plugins/module_utils/utils.py 9.52% 19 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #569       +/-   ##
===========================================
+ Coverage   18.14%   72.34%   +54.20%     
===========================================
  Files          91       55       -36     
  Lines        8395     5525     -2870     
  Branches     2196     1470      -726     
===========================================
+ Hits         1523     3997     +2474     
+ Misses       6871     1193     -5678     
- Partials        1      335      +334
Flag Coverage Δ
integration 72.34% <9.52%> (?)
sanity ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shrsr
shrsr previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross requested changes Nov 29, 2024
View reviewed changes
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
@sajagana
[ignore] Removed op from append_update_ops_data function argument and…
f7cdde1 
… updated the function logic to support replace and remove in one call
@sajagana sajagana dismissed stale reviews from samiib and shrsr via f7cdde1 November 29, 2024 16:28
This was referenced Dec 2, 2024
Merged
Merged
akinross
akinross previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samiib
samiib previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol previously approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr requested changes Dec 3, 2024
View reviewed changes
plugins/module_utils/utils.py Outdated Show resolved Hide resolved
@sajagana sajagana dismissed stale reviews from gmicol, samiib, and akinross via 5a7b48c December 4, 2024 09:41
samiib
samiib approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmicol
gmicol approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@gmicol gmicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 61fbd28 into CiscoDevNet:master Dec 4, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmicol gmicol gmicol approved these changes

@samiib samiib samiib approved these changes

@akinross akinross akinross approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot lhercot approved these changes

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

Assignees

@sajagana sajagana

Labels
jira-sync Sync this issue to Jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sajagana @lhercot @shrsr @akinross @samiib @gmicol