[minor_change] Added ndo_mcp_global_policy for fabric policy global MCP configuration (DCNE-70) #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiib
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana and
shrsr
as code owners
github-actions
bot
changed the title
shrsr
requested changes
Dec 3, 2024
akinross
requested changes
Dec 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #574 +/- ##
===========================================
- Coverage 72.58% 17.84% -54.74%
===========================================
Files 55 93 +38
Lines 5504 8791 +3287
Branches 1462 2322 +860
===========================================
- Hits 3995 1569 -2426
- Misses 1174 7221 +6047
+ Partials 335 1 -334
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
samiib
force-pushed
the
mcp_global_policy
branch
from
df330d3 to
8fe602d
Compare
samiib
force-pushed
the
mcp_global_policy
branch
from
8fe602d to
2f09443
Compare
akinross
requested changes
Dec 5, 2024
samiib
force-pushed
the
mcp_global_policy
branch
from
2f09443 to
7d7b199
Compare
anvitha-jain
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #451
This MCP Global policy module is based on a 1:1 relationship with Fabric Policy templates.
A decision was made to keep this configuration in a separate module instead of adding it to
ndo_template.