Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context: adding disable_searchdirs options #104

Closed
wants to merge 1 commit into from

Conversation

steweg
Copy link
Contributor

@steweg steweg commented Feb 28, 2024

This patch adds support to disable searching of local directories during loading of module

Copy link
Collaborator

@rjarry rjarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there,

The code looks good. The git commit message needs adjustments.

Could you:

  • Use imperative mood to describe your changes. e.g. add disable_searchdirs option instead of [I am] adding disable_searchdirs options, as if you are giving orders to the codebase to change its behaviour.
  • Use lowercase in the title (first line). E.g.: context: instead of Context:.
  • Sign-off your work using git commit --signoff

Thanks!

This patch adds support to disable searching of local directories during
loading of module

Signed-off-by: Stefan Gula <[email protected]>
@steweg
Copy link
Contributor Author

steweg commented Feb 28, 2024

Hi there,

The code looks good. The git commit message needs adjustments.

Could you:

* Use imperative mood to describe your changes. e.g. `add disable_searchdirs option` instead of `[I am] adding disable_searchdirs options`, as if you are giving orders to the codebase to change its behaviour.

* Use lowercase in the title (first line). E.g.: `context:` instead of `Context:`.

* Sign-off your work using `git commit --signoff`

Thanks!

Done

@steweg
Copy link
Contributor Author

steweg commented Feb 28, 2024

Closing this one as it will be merged in PR #103

@steweg steweg closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants