-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Context: adding ability to add custom load callback #103
Conversation
0ba20bc
to
7f42a37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please put the commit from #104 in this pull request? It will simplify testing.
Thanks.
7f42a37
to
e103f44
Compare
e103f44
to
17d01a2
Compare
Hi, libyang-python only supports the master branch of C libyang (currently 2.x). The lydevel check is only meant for informative purposes. Lines 18 to 20 in f09ed11
If it fails (currently it should fail because libyang 3.x is under development) it is not a problem. Could you remove all references to libyang 3 which was not released yet and only focus on the enhancements that you require? Thank you. |
17d01a2
to
61dd1da
Compare
Done |
61dd1da
to
506a1c0
Compare
Sorry for the delay on this... I pushed the first commit, but I don't understand what the second one does... Could you explain in more detail what you use it for, what it does exactly, and how it works? |
It allows you to define your own callback functions to load YANG modules if they are not found on in standard path. This is considered as sort of last resort option, which allows you to store YANG modules in remote/central locations and download it using some HTTP(s) client etc... libyang just tells you what file & version you should get, and it is up to your callback implementation to try to get it. |
91db3bd
to
e89419d
Compare
Pushed with minor changes, thanks! |
@steweg there is a problem with this pull request, can you look at this ignored exception? It can be reproduced by launching tox.
Thanks! |
e89419d
to
ebf1f1a
Compare
ebf1f1a
to
2cdb2f6
Compare
This patch fixes broken test related to get_module_data function Signed-off-by: Stefan Gula <[email protected]>
2cdb2f6
to
ca1848d
Compare
This patch adds ability to add custom load callback and also disable searchdirs options