-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRDCDH-1993 Submitter Study Assignment (1/2) – User Mgmt #554
Conversation
Pull Request Test Coverage Report for Build 12282310496Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the code LGTM, didn't test locally as the BE is not currently supporting it. Feel free to merge after verifying changes with BE.
The updated BE is deployed (and has some issues still). We're going to leave the updated BE deployed so this can be merged. Minor manual merge conflict resolutions dismissed a stale review, but I'm just going to bypass the merge requirements. |
Overview
This PR removes the concept of assigning organizations to accounts, and adds the ability to assign studies to a Submitter, among other changes.
Note
I marked
User
.organization
as deprecated, but I left it as apart of the type definition for now. Once collaborators no longer rely on organizations, this should be removed from the type definition and anywhere else it's referenced that I missed.Warning
The BE has several issues, as noted in CRDCDH-2009. The issues aren't catastrophic, so this can be merged without the fixes.
Change Details (Specifics)
User
.studies
fromstring[]
toApprovedStudy[]
User
.organization
as optional and deprecated, and remove it from most placesRelated Ticket(s)
CRDCDH-1993 (Task)
CRDCDH-1902 (US)