Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRDCDH-2036 Submitter Study Assignment (2/2) – Data Submissions #556

Merged
merged 5 commits into from
Dec 12, 2024
Merged

CRDCDH-2036 Submitter Study Assignment (2/2) – Data Submissions #556

merged 5 commits into from
Dec 12, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Dec 5, 2024 •
edited
Loading

Overview

This PR builds off of #554 by extending the concept of "studies assigned to submitters" to the Data Submission Creation dialog.

Change Details (Specifics)

  • Remove the listApprovedStudiesOfMyOrg API
  • Migrate the studies dropdown to values derived from the AuthCtx
  • HOTFIX: Add back the missing dbGaP bell icon (styling got reverted)

Related Ticket(s)

CRDCDH-2036 (Task)
CRDCDH-1902 (US)

@amattu2 amattu2 added this to the 3.2.0 (PMVP-M3) milestone Dec 5, 2024
@amattu2 amattu2 added the 🚧 Do Not Merge This PR is not ready for merging label Dec 5, 2024
@amattu2 amattu2 changed the title CRDCDH-2036 Submitter Study Assignment (2/2) – Data Submission Creation CRDCDH-2036 Submitter Study Assignment (2/2) – Data Submissions Dec 5, 2024
Base automatically changed from CRDCDH-1993 to 3.2.0 December 11, 2024 18:12
@coveralls
Copy link
Collaborator

coveralls commented Dec 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12301447296

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.721%
Totals Coverage Status
Change from base Build 12282661573: 0.0%
Covered Lines: 3797
Relevant Lines: 6229
💛 - Coveralls

@amattu2 amattu2 removed the 🚧 Do Not Merge This PR is not ready for merging label Dec 12, 2024
@amattu2 amattu2 marked this pull request as ready for review December 12, 2024 17:19
Alejandro-Vega
Alejandro-Vega approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit ab499c7 into 3.2.0 Dec 12, 2024
7 checks passed
@Alejandro-Vega Alejandro-Vega deleted the CRDCDH-2036 branch December 12, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alejandro-Vega Alejandro-Vega Alejandro-Vega approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0 (PMVP-M3)
Development

Successfully merging this pull request may close these issues.
3 participants
@amattu2 @coveralls @Alejandro-Vega