Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Random AuthContext test case failing in CI #309

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Mar 14, 2024

Overview

This PR aims to fix the random failures of the should update the localStorage cache when the user is verified test case for the AuthContext. It appears to be caused by a race condition.

e.g. https://github.com/CBIIT/crdc-datahub-ui/actions/runs/8100132739/job/22137439227

Change Details (Specifics)

  • Wrap the localStorage expectation in a Jest waitFor action which will continue to "re-test" the expect for up to 1 second before failing

Related Ticket(s)

N/A

@amattu2 amattu2 added this to the 2.1.0 (MVP2-M3) milestone Mar 14, 2024
@amattu2 amattu2 requested a review from Alejandro-Vega March 14, 2024 20:42
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alejandro-Vega Alejandro-Vega merged commit bd08f3e into mvp-2.1.0 Mar 15, 2024
2 checks passed
@Alejandro-Vega Alejandro-Vega deleted the fix-AuthCtx-test branch March 15, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants