Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AuthCtx expectation failing #314

Merged
merged 2 commits into from
Mar 18, 2024
Merged

fix: AuthCtx expectation failing #314

merged 2 commits into from
Mar 18, 2024

Conversation

amattu2
Copy link
Member

@amattu2 amattu2 commented Mar 18, 2024

Overview

Another PR to fix incorrectly written assertion in the AuthContext. This one has never failed in CI but just failed locally. See #309 for the same fix applied to a different case.

Screenshot 2024-03-18 at 12 53 21 PM

Change Details (Specifics)

  • Wrap localStorage accessing in a Jest waitFor stmt
  • Remove duplicate expectation

Related Ticket(s)

N/A

@amattu2 amattu2 added this to the 2.1.0 (MVP2-M3) milestone Mar 18, 2024
@amattu2 amattu2 marked this pull request as ready for review March 18, 2024 17:26
@amattu2 amattu2 requested a review from Alejandro-Vega March 18, 2024 17:27
Copy link
Collaborator

@Alejandro-Vega Alejandro-Vega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Didn't test locally

@Alejandro-Vega Alejandro-Vega merged commit 160a7b4 into mvp-2.1.0 Mar 18, 2024
3 checks passed
@Alejandro-Vega Alejandro-Vega deleted the AuthCTX-fix-v2 branch March 18, 2024 17:35
@amattu2 amattu2 added the Not Run This PR was not tested locally label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Not Run This PR was not tested locally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants