Updating vdiff goldens for PR 190 #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dlockhart
approved these changes
Sep 25, 2023
svanherk
added a commit
that referenced
this pull request
Sep 25, 2023
* Add new tests to highlight the overflow/scrolling RTL issue * Temporarily force golden mode * Updating vdiff goldens (#191) Co-authored-by: github-actions <[email protected]> * If RTL and scrolled/overflowing, turn on fullPage mode and handle rect calculation ourselves * Updating vdiff goldens (#192) Co-authored-by: github-actions <[email protected]> * Put tests back to regular mode --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the vdiff goldens for the changes in pull request #190.
Please review the resulting report closely before merging to ensure the visual differences are expected.