US152268 - Handle RTL scrolling/overflow cases #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: github-actions <[email protected]>
…t calculation ourselves
dlockhart
reviewed
Sep 25, 2023
Co-authored-by: github-actions <[email protected]>
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of how Playwright screenshots work, overflow and scrolling in RTL is not handled properly when capturing beyond the viewport is off. But if we force it on, we have to do all the calculations ourselves. This PR tries to do those in the background automatically, if we detect we are in RTL mode and overflowing (negative
xvalue) or scrolling (window.scrollXvalue).I've first pushed the new tests to highlight the issue, and merged those goldens in. Then I added the fix, so this second report shows what used to be captured and what is now captured.
From what I can tell running it locally, none of the current
coretests hit this new calculation (which is expected). Once this is in, I'll open the table PR that needs it.