Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set model_template to NULL for virtual node populations in examples 2 & 4 #50

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Set model_template to NULL for virtual node populations in examples 2 & 4 #50

wants to merge 4 commits into from

Conversation

KeremKurban
Copy link
Member

Fixed virtual node pop examples in example 2 and example 4 not having model_template. Set to 'NULL' according to documentation here

@KeremKurban
Copy link
Member Author

related to #49

@KeremKurban KeremKurban requested a review from jdcourcol March 4, 2024 16:10
@jdcourcol
Copy link
Collaborator

probably best to update the sonata generator. I let @joni-herttuainen manage

@joni-herttuainen joni-herttuainen mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdcourcol jdcourcol Awaiting requested review from jdcourcol

@joni-herttuainen joni-herttuainen Awaiting requested review from joni-herttuainen

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KeremKurban @jdcourcol