Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples by re-running with up-to-date sonata-generator #51

Merged
merged 1 commit into from
May 13, 2024

Conversation

joni-herttuainen
Copy link
Contributor

@joni-herttuainen joni-herttuainen commented Mar 6, 2024

Notes:

  • kept the originals in v2 directory of GPFS
    • copied the directory to v3 and overwrite what was updated
  • bunch of data seems to change in the re-run, due to random and things being changed since it was originally run
    • re-running again now does not change the data in the files

closes #49 and #50

@joni-herttuainen joni-herttuainen self-assigned this Mar 6, 2024
DATA {
"dNAC", "dSTUT"
"dSTUT"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure why this has changed (in usecase 1) too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this is due to samples being drawn randomly. In the usecase config we have

# from usecase_examples/config/nodes_configuration.yaml
etype:
  type: text
  values: [ "dNAC", "dSTUT" ]

and we only draw 2 samples, and since both of them were "dSTUT" only that value is represented in the @library.

source/usecases/usecase2/nodes.h5.txt Show resolved Hide resolved
source/usecases/usecase4/projections_B.h5.txt Show resolved Hide resolved
@joni-herttuainen joni-herttuainen requested a review from mgeplf March 26, 2024 09:21
Copy link
Collaborator

@mgeplf mgeplf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing jumps out at me, but there's a lot to check.

@joni-herttuainen
Copy link
Contributor Author

Yeah, unfortunately the fields added after the original run messes up the predicted results of the pseudo-randomness even though the seed hasn't changed.

So, basically, everytime a circuit is created, the first node file that is created has the same values, until we create a field that wasn't in the original run. All the random values after that (for that circuit) will be different for rest of the fields and files.

What we could do, before this goes in, is to instantiate each of the file generators with a with a seed to ensure that if we add fields in the future, not everything is changed (such as in this PR). But that would only make sense if we foresee that we're going to have to add new fields in the future.

@joni-herttuainen joni-herttuainen merged commit 9d904b9 into master May 13, 2024
@mgeplf mgeplf deleted the re-run-examples branch May 16, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example Circuits Not Passing Circuit Validation
3 participants