Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting use_range_ptr_var NmodlType in SymTab #1139

Merged
merged 9 commits into from
Feb 9, 2024
Merged

Conversation

iomaganaris
Copy link
Contributor

@iomaganaris iomaganaris commented Jan 11, 2024

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (d70c51b) 88.07% compared to head (7c5e724) 88.16%.

Files Patch % Lines
src/visitors/function_callpath_visitor.cpp 63.82% 17 Missing ⚠️
src/symtab/symbol_properties.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1139      +/-   ##
==========================================
+ Coverage   88.07%   88.16%   +0.08%     
==========================================
  Files         175      176       +1     
  Lines       12614    12684      +70     
==========================================
+ Hits        11110    11183      +73     
+ Misses       1504     1501       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@iomaganaris iomaganaris marked this pull request as ready for review January 15, 2024 15:46
@iomaganaris iomaganaris changed the title Added visitor for setting need_setdata NmodlType in SymTab Setting need_setdata NmodlType in SymTab Jan 16, 2024
@bbpbuildbot

This comment has been minimized.

@pramodk pramodk added the NEURON codegen Work toward NEURON code generation label Jan 17, 2024
@iomaganaris iomaganaris marked this pull request as draft January 22, 2024 10:37
@iomaganaris iomaganaris marked this pull request as ready for review January 23, 2024 15:56
@iomaganaris
Copy link
Contributor Author

With the latest changes in this PR #1138 shouldn't be needed

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@iomaganaris iomaganaris changed the title Setting need_setdata NmodlType in SymTab Setting use_range_ptr_var NmodlType in SymTab Jan 26, 2024
@bbpbuildbot

This comment has been minimized.

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #192501 (:white_check_mark:) have been uploaded here!

Status and direct links:

Copy link
Contributor

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit here but this is much more clean and better! I like it this way!

@pramodk pramodk merged commit d1290e0 into master Feb 9, 2024
20 checks passed
@pramodk pramodk deleted the magkanar/need_setdata branch February 9, 2024 17:48
ohm314 pushed a commit that referenced this pull request May 21, 2024
Created FunctionCallpathVisitor that traverses the function calls
and sets `use_range_ptr_var` property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NEURON codegen Work toward NEURON code generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants