-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting use_range_ptr_var
NmodlType in SymTab
#1139
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1139 +/- ##
==========================================
+ Coverage 88.07% 88.16% +0.08%
==========================================
Files 175 176 +1
Lines 12614 12684 +70
==========================================
+ Hits 11110 11183 +73
+ Misses 1504 1501 -3 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
need_setdata
NmodlType in SymTabneed_setdata
NmodlType in SymTab
This comment has been minimized.
This comment has been minimized.
With the latest changes in this PR #1138 shouldn't be needed |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…d sets need_setdata property
need_setdata
NmodlType in SymTabuse_range_ptr_var
NmodlType in SymTab
This comment has been minimized.
This comment has been minimized.
Logfiles from GitLab pipeline #192501 (:white_check_mark:) have been uploaded here! Status and direct links: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit here but this is much more clean and better! I like it this way!
Created FunctionCallpathVisitor that traverses the function calls and sets `use_range_ptr_var` property
FUNCTION
andPROCEDURE
codegen for NEURONfunc_needs_setdata()
from Allow segment.mechanism.func(args) neuronsimulator/nrn#2475