FUNCTION and PROCEDURE codegen for NEURON #1141
Conversation
This reverts commit a18b1b8.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
@iomaganaris: I went through this, just to be sure that if there are any major questions then I can post them / get them clarified.
Few minor questions/comments otherwise it's OK and on our side we can move forward this.
…d sets need_setdata property
This comment has been minimized.
This comment has been minimized.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1141 +/- ##
==========================================
+ Coverage 88.18% 88.38% +0.19%
==========================================
Files 176 176
Lines 12791 12946 +155
==========================================
+ Hits 11280 11442 +162
+ Misses 1511 1504 -7 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…from nmodl parser
|
Logfiles from GitLab pipeline #192576 (:white_check_mark:) have been uploaded here! Status and direct links: |
There was a problem hiding this comment.
LGTM.
- I have merged the master and reviewed the changes.
The only noticeable thing I have changed is in c3edb59
@@ -853,31 +852,19 @@ void CodegenNeuronCppVisitor::print_global_variables_for_hoc() {
printer->add_line("/* declaration of user functions */");
for (const auto& procedure: info.procedures) {
const auto proc_name = procedure->get_node_name();
- if (proc_name[0] == '_') {
- continue;
- }i.e. removal of check of _ in the function/procedure name. NMODL language doesn't allow it and I believe the info.procedures & info.functions don't contain any methods with _ at the beginning. So I am removing that check.
Also, I checked the test with a GLOBAL variable usage in efe963c and it's working fine.
* Added support for the usage of FUNCTION and PROCEDURES * hoc and python wrappers registration also done * Corresponding tests added
use_range_ptr_varNmodlType in SymTab #1139 and Add more logic for POINT_PROCESS registration function #1106