-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bips 16468 release please #5
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| releaseType: simple |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,22 @@ | ||
| # go-client-library-passwordsafe | ||
| This Go client library makes it easier to access Password Safe APIs. Provide simplifications that significantly reduce the amount of code you need to write. | ||
|
|
||
| ## Release Please App usage | ||
|
|
||
| In order to use Release Please App, we need to use [Conventional commits](https://beyondtrust.atlassian.net/wiki/spaces/DEVOPS/pages/380699165/Releasing+Software#4.-Trigger-the-app), but [here](https://github.com/angular/angular/blob/22b96b9/CONTRIBUTING.md#type) is a more comprehensive guide about some conventional commits that we can use. | ||
|
|
||
| Some of the more important and common commit types are: | ||
|
|
||
| |Type |Description |Triggers Release Please| | ||
| |:-------|:------------------------------------------------------------|:----------------------| | ||
| |feat! |Introduce a major change e.g. v1.0.0 to v2.0.0 |Yes | | ||
| |feat |Introduce a minor change e.g. v1.0.0 to v1.1.0 |Yes | | ||
| |fix |Introduce a patch change e.g. v1.0.0 to v1.0.1 |Yes | | ||
| |chore |Could introduce a BREAKING CHANGE into the CHANGELOG |Yes | | ||
| |docs |Documentation update |No | | ||
| |refactor|A code change that neither fixes a bug nor adds a feature |No | | ||
| |test |Adding or modifying tests |No | | ||
| |build |Changes that affect the build system or external dependencies|No | | ||
| |ci |Changes to CI configuration files and scripts |No | | ||
|
|
||
| Remember, Release Please App will trigger once a PR with the conventional commit structure are merged into the main branch, so if you are working on features that are related to a Jira ticket, you can still use **feat** while developing, and because we can squash the commits once we want to merge the PR, only one commit with the conventional syntax will be on the history and on the changelog. | ||
Empty file.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ivan, could you set the release please version to be 0.0.0 to start with? just while we are developing the library.
When we are finished we will change it to a 1.0.0 version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, so going to change the release type to simple to get into version 0.0.0, that can be our best option.