Bips 16468 release please #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejurysays
suggested changes
Feb 13, 2024
| |:-------|:------------------------------------------------------------|:----------------------| | ||
| |feat! |Introduce a major change e.g. v1.0.0 to v2.0.0 |Yes | | ||
| |feat |Introduce a minor change e.g. v1.0.0 to v1.1.0 |Yes | | ||
| |fix |Introduce a patch change e.g. v1.0.0 to v1.0.1 |Yes | |
There was a problem hiding this comment.
Ivan, could you set the release please version to be 0.0.0 to start with? just while we are developing the library.
When we are finished we will change it to a 1.0.0 version
There was a problem hiding this comment.
Ok, so going to change the release type to simple to get into version 0.0.0, that can be our best option.
thejurysays
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Jira ticket BIPS-16468