Refactor Program Management section of Admin Settings #1281
Conversation
saving solution in route, currently get system error.
some white space and useless comments and moved some css to its proper location. Image solution still doesn't work, will ask a higher power about it on monday
file handler, was trying to use userManagement.py
except as a foreign key value in program to store one charfield variable. Add some things to hopefully handle files, not working. Updated the test data to contain added data fields.
some variables
…rrently attempting to change the file name to the name of the program along with the file extension.
…dal and the msgToast is also in front of the modal and clearly visible.
…ts still not passed FileStorage issue.
Merge branch 'refactorProgramMgmt' of github.com:BCStudentSoftwareDevTeam/celts into refactorProgramMgmt
…Team/celts into refactorProgramMgmt
|
When trying to upload a picture for a event, if you exit out of the modal and open it the file name will still be there and the same file will still be uploaded if saved. I suggest clearing the picture and file name when the user exits the modal. 
|
|
For the following programs, when trying to change the event picture in settings the picture doesn't change: -Berea Teen Mentoring |
@thealphagurlux I double checked these on my machine and Anna's and we could not replicate the issue you found. |
|
I had not reset my database or restored the git branch while looking for bugs. This is what was causing the issue. |
| filePaths = FileHandler(programId=programID).retrievePath(associatedAttachments) | ||
|
|
||
|
|
||
| file_paths = {filename: path_info[0] for filename, path_info in filePaths.items()} |
There was a problem hiding this comment.
The "filePaths" variable and the "file_paths" variable should be both camelcase. The also should have different variable names.
| fileType = file.filename.split('.')[-1] | ||
| fileName = f"{self.programId}.{fileType}" | ||
| AttachmentUpload.create(program=self.programId, fileName=fileName) | ||
| current_programID = fileName |
There was a problem hiding this comment.
should be camelCase
| flash("Program updated", "success") | ||
| return redirect(url_for("admin.userManagement", accordion="program")) | ||
| except Exception as e: | ||
| print(e) | ||
| flash('Error while updating program info.','warning') | ||
| print("error: ", e) |
There was a problem hiding this comment.
Get rid of the ``"print("error: ", e)" `we don't need it.
| if (single){ | ||
| $(objectContainerId).html(fileHTML) | ||
| } | ||
| else{ | ||
| msgToast("File with filename '" + file.name + "' has already been added to this event") |
| AttachmentUpload.create(program=self.programId, fileName=fileName) | ||
| current_programID = fileName | ||
| saveFileToFilesystem = current_programID | ||
|
|
There was a problem hiding this comment.
I think using snake_case for variable naming is better.
deleteFileObject to delete_file_object.
fileType to file_type.
fileName to file_name.
Issue
Issue: #797
Changes
Testing
refactorProgramMgmt./database/reset_database.sh testflask runapp/static/files/programattachmentsand make sure that there is only one file for each program (1.jpg, 2.png, etc.)git restore .