-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new module avm/res/elastic-san/elastic-san #3809
Open
jbinko
wants to merge
162
commits into
Azure:main
Choose a base branch
from
jbinko:avm-res-elastic-san
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11,525
−0
Open
Changes from 152 commits
Commits
Show all changes
162 commits
Select commit
Hold shift + click to select a range
86c7ec3
Init Commit
jbinko fc9eeac
volume code complete
jbinko 479c512
snapshot code complete
jbinko 6864177
Elastic SAN Volume Snapshots
jbinko 187efca
code complete
jbinko 6f8d66c
update
jbinko 4d1741b
virtualNetworkRules
jbinko 2ceca55
update
jbinko 9ad3a9f
update
jbinko 40d765e
update
jbinko 7ed2e4b
update
jbinko 66a044f
update
jbinko a188845
update
jbinko 56441f9
encryptionProperties fix
jbinko 0fe7ef2
update
jbinko 0a73619
update
jbinko 7dcc84d
fix
jbinko d6a2281
fix
jbinko 795a0e2
calculatedPublicNetworkAccess change
jbinko e066f46
systemAssignedMIPrincipalId is NOT supported
jbinko cd5201c
corrected systemAssignedMIPrincipalId
jbinko 5211ca8
managedIdentityAllType, customerManagedKeyType
jbinko 61e33fa
Deny is not allowed for Network Rule Action.
jbinko c83e2f5
better description
jbinko fdecaa0
CMK requires KV with enabled purge protection
jbinko 7c0baf7
params update
jbinko 0654dc3
Descriptions update
jbinko b2a89ea
updated descriptions
jbinko 44270d7
update
jbinko 7d86b5e
update
jbinko f7f55a3
update
jbinko 2f727e8
update
jbinko 0110f5b
update
jbinko 2411bd6
update
jbinko bb87473
enforcedLocation
jbinko 33a3a9a
tests
jbinko de5b238
tests
jbinko 8b34850
tests
jbinko fa253fa
fix
jbinko c406e65
Test fix
jbinko f0e1459
Description details
jbinko 6e23ffc
update volume groups
jbinko 6cea208
Expanding comments
jbinko a7e05f0
Added @sys.
jbinko 3efca44
test changes
jbinko 71a3727
test update
jbinko 0d07591
test snapshot unique name
jbinko 984e891
snapshot iteration
jbinko 2220993
common tests
jbinko c45e69a
tests update
jbinko 86c3bae
tests fix
jbinko 7ecb386
Location $null
jbinko 10cf978
location fix
jbinko 61d2718
Location fix
jbinko f540f70
update
jbinko 06407ec
update
jbinko 0334f56
update
jbinko 76a4012
test fixes
jbinko 3b1819f
test fix
jbinko 42fb896
test changes
jbinko c40df50
volume code complete
jbinko 57ef9a8
tests optimizations
jbinko 03e4f09
tests refactoring
jbinko 27fe02a
tests
jbinko 94abe29
Tests Refactoring
jbinko cf3e874
Tests fix
jbinko ca05f8b
Test fix
jbinko 0a3212b
Test Fix
jbinko ee666ec
tests fix
jbinko 4aed218
Expanded Tests
jbinko 5eb9d41
Test Changes
jbinko d1aa5a9
update
jbinko ec80315
kv update
jbinko 10a69a8
Tests update
jbinko a598fc4
test changes
jbinko bc64c59
Description updated
jbinko b56990f
Tests update
jbinko fc3a0a3
Test updates
jbinko cc201cd
Description Updates
jbinko 8d6974f
Tests Updates
jbinko 8bd9bd9
Test fix
jbinko 0b5d288
Test changes
jbinko 080c06a
test fix
jbinko 9389de8
Tests update
jbinko 9477edf
test fix
jbinko f7c45c3
tests update
jbinko 9db00b0
Key Vault Crypto Service Encryption User
jbinko 1e3d77b
Tests update
jbinko 707832e
tests update
jbinko 87450ab
Tests fix
jbinko 6f592cb
Tests refactoring
jbinko dac8c1e
cmk test
jbinko 0696b8c
test fix
jbinko eb2a283
Tests fix
jbinko 7d01e5e
test fix
jbinko 34253a0
Merge branch 'Azure:main' into avm-res-elastic-san
jbinko bda00bc
Upgrade to /avm-common-types:0.3.0
jbinko 8f1c1db
PE test
jbinko 644a1de
update
jbinko dbb4696
pe tests
jbinko 57c34c7
tests update
jbinko 6bff945
test change
jbinko f95f374
test update
jbinko dca007a
tests fix
jbinko 2810eaf
test fix
jbinko 65eaa45
totalPrivateEndpoints
jbinko 87cbe5c
test update
jbinko ee7a27c
test fix
jbinko 637a4b4
tests update
jbinko 1ec461b
test update
jbinko a4e57f4
test update
jbinko 59c66d8
PEP changes
jbinko 7f58908
PE Test Update
jbinko 9afe578
PEP Update
jbinko 6613569
snapshot location
jbinko e41b47b
location cascading changes
jbinko 897fe12
Location Tests
jbinko be6311b
Expanded test
jbinko 52e17be
Updated module
jbinko cde74d3
PE Tests
jbinko 41a4659
tests fix
jbinko 1e9bf21
readme re-gen
jbinko d925952
test fix
jbinko 8ef85ca
Test fix
jbinko 07ce4f0
Test fix
jbinko 95d001a
Test fix
jbinko f23f8b1
@sys.export()
jbinko 87a1b92
Tests expanded
jbinko dc37144
PEP Test-VerifyLock
jbinko d964554
Test update
jbinko 9e18545
init waf test
jbinko 782584e
test update
jbinko d80cc8f
Private Endpoints with support for ZRS
jbinko 33f7d80
Test changes
jbinko 9c02e53
test changes
jbinko 7a3de1c
test update
jbinko ab6cf97
Update
jbinko 79c74b0
test update
jbinko 69d2fcd
WAF Test Update
jbinko 299cdcf
Test Lock
jbinko 9b5e614
Test Update
jbinko ae52fed
PrivateEndpoints Test Update
jbinko fec1de1
Test Fix
jbinko 9a313f4
Role assignments
jbinko ba5e5f3
Role Assignment Tests
jbinko 103be19
Role Assignments Tests Changes
jbinko 3bc2f08
added diagnosticSettings
jbinko 3898a88
Fix
jbinko c7aad09
Diag Testing
jbinko cd7811a
Test Update
jbinko 9cc2f12
test fix
jbinko 01054fc
Merge branch 'main' into avm-res-elastic-san
jbinko bd711e1
Removed Doc must be between X and Y characters long.
jbinko 39d99c7
Merge branch 'Azure:main' into avm-res-elastic-san
jbinko 3c00aee
Update avm/res/elastic-san/elastic-san/volume-group/snapshot/main.bicep
jbinko f78ef33
Update avm/res/elastic-san/elastic-san/volume-group/snapshot/main.bicep
jbinko f372203
Update avm/res/elastic-san/elastic-san/volume-group/volume/main.bicep
jbinko f5cd132
Update avm/res/elastic-san/elastic-san/main.bicep
jbinko 93123c3
Update avm/res/elastic-san/elastic-san/main.bicep
jbinko 2a090cb
Moving resource group in tests
jbinko c3e042d
Tags moved to the code to be documented as part of the example
jbinko 02b7450
Removed Lock from the WAF Test Case.
jbinko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
name: "avm.res.elastic-san.elastic-san" | ||
|
||
on: | ||
workflow_dispatch: | ||
inputs: | ||
staticValidation: | ||
type: boolean | ||
description: "Execute static validation" | ||
required: false | ||
default: true | ||
deploymentValidation: | ||
type: boolean | ||
description: "Execute deployment validation" | ||
required: false | ||
default: true | ||
removeDeployment: | ||
type: boolean | ||
description: "Remove deployed module" | ||
required: false | ||
default: true | ||
customLocation: | ||
type: string | ||
description: "Default location overwrite (e.g., eastus)" | ||
required: false | ||
push: | ||
branches: | ||
- main | ||
paths: | ||
- ".github/actions/templates/avm-**" | ||
- ".github/workflows/avm.template.module.yml" | ||
- ".github/workflows/avm.res.elastic-san.elastic-san.yml" | ||
- "avm/res/elastic-san/elastic-san/**" | ||
- "avm/utilities/pipelines/**" | ||
- "!avm/utilities/pipelines/platform/**" | ||
- "!*/**/README.md" | ||
|
||
env: | ||
modulePath: "avm/res/elastic-san/elastic-san" | ||
workflowPath: ".github/workflows/avm.res.elastic-san.elastic-san.yml" | ||
|
||
concurrency: | ||
group: ${{ github.workflow }} | ||
|
||
jobs: | ||
########################### | ||
# Initialize pipeline # | ||
########################### | ||
job_initialize_pipeline: | ||
runs-on: ubuntu-latest | ||
name: "Initialize pipeline" | ||
steps: | ||
- name: "Checkout" | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 | ||
- name: "Set input parameters to output variables" | ||
id: get-workflow-param | ||
uses: ./.github/actions/templates/avm-getWorkflowInput | ||
with: | ||
workflowPath: "${{ env.workflowPath}}" | ||
- name: "Get module test file paths" | ||
id: get-module-test-file-paths | ||
uses: ./.github/actions/templates/avm-getModuleTestFiles | ||
with: | ||
modulePath: "${{ env.modulePath }}" | ||
outputs: | ||
workflowInput: ${{ steps.get-workflow-param.outputs.workflowInput }} | ||
moduleTestFilePaths: ${{ steps.get-module-test-file-paths.outputs.moduleTestFilePaths }} | ||
psRuleModuleTestFilePaths: ${{ steps.get-module-test-file-paths.outputs.psRuleModuleTestFilePaths }} | ||
modulePath: "${{ env.modulePath }}" | ||
|
||
############################## | ||
# Call reusable workflow # | ||
############################## | ||
call-workflow-passing-data: | ||
name: "Run" | ||
permissions: | ||
id-token: write # For OIDC | ||
contents: write # For release tags | ||
needs: | ||
- job_initialize_pipeline | ||
uses: ./.github/workflows/avm.template.module.yml | ||
with: | ||
workflowInput: "${{ needs.job_initialize_pipeline.outputs.workflowInput }}" | ||
moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}" | ||
psRuleModuleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.psRuleModuleTestFilePaths }}" | ||
modulePath: "${{ needs.job_initialize_pipeline.outputs.modulePath}}" | ||
secrets: inherit |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note, the team either does not yet exist, or is not yet approved in the hierachy of teams (ref)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my bad, I created the groups with prefix "@Azure" => "@Azure/avm-res-elasticsan-elasticsan-module-owners-bicep" and "@Azure/avm-res-elasticsan-elasticsan-module-contributors-bicep". I deleted those teams and created new ones: "avm-res-elasticsan-elasticsan-module-owners-bicep" and "avm-res-elasticsan-elasticsan-module-contributors-bicep".
BTW I'm seeing I was not the only one who did this mistake. I can see more teams with prefix "@Azure" - see: https://github.com/orgs/Azure/teams?query=%40azure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's actually one more step to it. Once the teams were created, they also have to be placed in the correct hierachy of teams - most notably the reviewer & contributor groups. This will enable your team to approve subsequent PRs for this module.
If correctly requested, one of the PMs should get a noticiation and approve the new child team request in no time :)
cc: @matebarabas