Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new module avm/res/elastic-san/elastic-san #3809

Open
wants to merge 162 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 152 commits
Commits
Show all changes
162 commits
Select commit Hold shift + click to select a range
86c7ec3
Init Commit
jbinko Oct 28, 2024
fc9eeac
volume code complete
jbinko Oct 30, 2024
479c512
snapshot code complete
jbinko Oct 30, 2024
6864177
Elastic SAN Volume Snapshots
jbinko Oct 31, 2024
187efca
code complete
jbinko Oct 31, 2024
6f8d66c
update
jbinko Nov 1, 2024
4d1741b
virtualNetworkRules
jbinko Nov 1, 2024
2ceca55
update
jbinko Nov 1, 2024
9ad3a9f
update
jbinko Nov 1, 2024
40d765e
update
jbinko Nov 1, 2024
7ed2e4b
update
jbinko Nov 1, 2024
66a044f
update
jbinko Nov 1, 2024
a188845
update
jbinko Nov 2, 2024
56441f9
encryptionProperties fix
jbinko Nov 2, 2024
0fe7ef2
update
jbinko Nov 2, 2024
0a73619
update
jbinko Nov 2, 2024
7dcc84d
fix
jbinko Nov 2, 2024
d6a2281
fix
jbinko Nov 2, 2024
795a0e2
calculatedPublicNetworkAccess change
jbinko Nov 2, 2024
e066f46
systemAssignedMIPrincipalId is NOT supported
jbinko Nov 2, 2024
cd5201c
corrected systemAssignedMIPrincipalId
jbinko Nov 2, 2024
5211ca8
managedIdentityAllType, customerManagedKeyType
jbinko Nov 2, 2024
61e33fa
Deny is not allowed for Network Rule Action.
jbinko Nov 2, 2024
c83e2f5
better description
jbinko Nov 2, 2024
fdecaa0
CMK requires KV with enabled purge protection
jbinko Nov 2, 2024
7c0baf7
params update
jbinko Nov 9, 2024
0654dc3
Descriptions update
jbinko Nov 9, 2024
b2a89ea
updated descriptions
jbinko Nov 9, 2024
44270d7
update
jbinko Nov 9, 2024
7d86b5e
update
jbinko Nov 9, 2024
f7f55a3
update
jbinko Nov 9, 2024
2f727e8
update
jbinko Nov 9, 2024
0110f5b
update
jbinko Nov 9, 2024
2411bd6
update
jbinko Nov 9, 2024
bb87473
enforcedLocation
jbinko Nov 9, 2024
33a3a9a
tests
jbinko Nov 9, 2024
de5b238
tests
jbinko Nov 9, 2024
8b34850
tests
jbinko Nov 9, 2024
fa253fa
fix
jbinko Nov 9, 2024
c406e65
Test fix
jbinko Nov 9, 2024
f0e1459
Description details
jbinko Nov 9, 2024
6e23ffc
update volume groups
jbinko Nov 9, 2024
6cea208
Expanding comments
jbinko Nov 9, 2024
a7e05f0
Added @sys.
jbinko Nov 9, 2024
3efca44
test changes
jbinko Nov 9, 2024
71a3727
test update
jbinko Nov 10, 2024
0d07591
test snapshot unique name
jbinko Nov 10, 2024
984e891
snapshot iteration
jbinko Nov 10, 2024
2220993
common tests
jbinko Nov 10, 2024
c45e69a
tests update
jbinko Nov 10, 2024
86c3bae
tests fix
jbinko Nov 10, 2024
7ecb386
Location $null
jbinko Nov 10, 2024
10cf978
location fix
jbinko Nov 10, 2024
61d2718
Location fix
jbinko Nov 10, 2024
f540f70
update
jbinko Nov 10, 2024
06407ec
update
jbinko Nov 10, 2024
0334f56
update
jbinko Nov 10, 2024
76a4012
test fixes
jbinko Nov 10, 2024
3b1819f
test fix
jbinko Nov 10, 2024
42fb896
test changes
jbinko Nov 10, 2024
c40df50
volume code complete
jbinko Nov 10, 2024
57ef9a8
tests optimizations
jbinko Nov 10, 2024
03e4f09
tests refactoring
jbinko Nov 10, 2024
27fe02a
tests
jbinko Nov 10, 2024
94abe29
Tests Refactoring
jbinko Nov 10, 2024
cf3e874
Tests fix
jbinko Nov 10, 2024
ca05f8b
Test fix
jbinko Nov 10, 2024
0a3212b
Test Fix
jbinko Nov 10, 2024
ee666ec
tests fix
jbinko Nov 11, 2024
4aed218
Expanded Tests
jbinko Nov 11, 2024
5eb9d41
Test Changes
jbinko Nov 11, 2024
d1aa5a9
update
jbinko Nov 11, 2024
ec80315
kv update
jbinko Nov 11, 2024
10a69a8
Tests update
jbinko Nov 11, 2024
a598fc4
test changes
jbinko Nov 11, 2024
bc64c59
Description updated
jbinko Nov 11, 2024
b56990f
Tests update
jbinko Nov 11, 2024
fc3a0a3
Test updates
jbinko Nov 11, 2024
cc201cd
Description Updates
jbinko Nov 11, 2024
8d6974f
Tests Updates
jbinko Nov 11, 2024
8bd9bd9
Test fix
jbinko Nov 11, 2024
0b5d288
Test changes
jbinko Nov 11, 2024
080c06a
test fix
jbinko Nov 11, 2024
9389de8
Tests update
jbinko Nov 11, 2024
9477edf
test fix
jbinko Nov 11, 2024
f7c45c3
tests update
jbinko Nov 11, 2024
9db00b0
Key Vault Crypto Service Encryption User
jbinko Nov 12, 2024
1e3d77b
Tests update
jbinko Nov 12, 2024
707832e
tests update
jbinko Nov 12, 2024
87450ab
Tests fix
jbinko Nov 12, 2024
6f592cb
Tests refactoring
jbinko Nov 12, 2024
dac8c1e
cmk test
jbinko Nov 12, 2024
0696b8c
test fix
jbinko Nov 12, 2024
eb2a283
Tests fix
jbinko Nov 12, 2024
7d01e5e
test fix
jbinko Nov 12, 2024
34253a0
Merge branch 'Azure:main' into avm-res-elastic-san
jbinko Nov 12, 2024
bda00bc
Upgrade to /avm-common-types:0.3.0
jbinko Nov 12, 2024
8f1c1db
PE test
jbinko Nov 12, 2024
644a1de
update
jbinko Nov 12, 2024
dbb4696
pe tests
jbinko Nov 12, 2024
57c34c7
tests update
jbinko Nov 12, 2024
6bff945
test change
jbinko Nov 12, 2024
f95f374
test update
jbinko Nov 12, 2024
dca007a
tests fix
jbinko Nov 12, 2024
2810eaf
test fix
jbinko Nov 12, 2024
65eaa45
totalPrivateEndpoints
jbinko Nov 12, 2024
87cbe5c
test update
jbinko Nov 12, 2024
ee7a27c
test fix
jbinko Nov 12, 2024
637a4b4
tests update
jbinko Nov 12, 2024
1ec461b
test update
jbinko Nov 12, 2024
a4e57f4
test update
jbinko Nov 12, 2024
59c66d8
PEP changes
jbinko Nov 14, 2024
7f58908
PE Test Update
jbinko Nov 14, 2024
9afe578
PEP Update
jbinko Nov 14, 2024
6613569
snapshot location
jbinko Nov 14, 2024
e41b47b
location cascading changes
jbinko Nov 14, 2024
897fe12
Location Tests
jbinko Nov 14, 2024
be6311b
Expanded test
jbinko Nov 14, 2024
52e17be
Updated module
jbinko Nov 14, 2024
cde74d3
PE Tests
jbinko Nov 14, 2024
41a4659
tests fix
jbinko Nov 14, 2024
1e9bf21
readme re-gen
jbinko Nov 14, 2024
d925952
test fix
jbinko Nov 14, 2024
8ef85ca
Test fix
jbinko Nov 14, 2024
07ce4f0
Test fix
jbinko Nov 14, 2024
95d001a
Test fix
jbinko Nov 14, 2024
f23f8b1
@sys.export()
jbinko Nov 16, 2024
87a1b92
Tests expanded
jbinko Nov 16, 2024
dc37144
PEP Test-VerifyLock
jbinko Nov 16, 2024
d964554
Test update
jbinko Nov 16, 2024
9e18545
init waf test
jbinko Nov 16, 2024
782584e
test update
jbinko Nov 16, 2024
d80cc8f
Private Endpoints with support for ZRS
jbinko Nov 16, 2024
33f7d80
Test changes
jbinko Nov 16, 2024
9c02e53
test changes
jbinko Nov 16, 2024
7a3de1c
test update
jbinko Nov 16, 2024
ab6cf97
Update
jbinko Nov 16, 2024
79c74b0
test update
jbinko Nov 16, 2024
69d2fcd
WAF Test Update
jbinko Nov 16, 2024
299cdcf
Test Lock
jbinko Nov 16, 2024
9b5e614
Test Update
jbinko Nov 16, 2024
ae52fed
PrivateEndpoints Test Update
jbinko Nov 16, 2024
fec1de1
Test Fix
jbinko Nov 17, 2024
9a313f4
Role assignments
jbinko Nov 18, 2024
ba5e5f3
Role Assignment Tests
jbinko Nov 18, 2024
103be19
Role Assignments Tests Changes
jbinko Nov 18, 2024
3bc2f08
added diagnosticSettings
jbinko Nov 18, 2024
3898a88
Fix
jbinko Nov 18, 2024
c7aad09
Diag Testing
jbinko Nov 18, 2024
cd7811a
Test Update
jbinko Nov 18, 2024
9cc2f12
test fix
jbinko Nov 19, 2024
01054fc
Merge branch 'main' into avm-res-elastic-san
jbinko Nov 19, 2024
bd711e1
Removed Doc must be between X and Y characters long.
jbinko Nov 26, 2024
39d99c7
Merge branch 'Azure:main' into avm-res-elastic-san
jbinko Nov 26, 2024
3c00aee
Update avm/res/elastic-san/elastic-san/volume-group/snapshot/main.bicep
jbinko Nov 26, 2024
f78ef33
Update avm/res/elastic-san/elastic-san/volume-group/snapshot/main.bicep
jbinko Nov 26, 2024
f372203
Update avm/res/elastic-san/elastic-san/volume-group/volume/main.bicep
jbinko Nov 26, 2024
f5cd132
Update avm/res/elastic-san/elastic-san/main.bicep
jbinko Nov 26, 2024
93123c3
Update avm/res/elastic-san/elastic-san/main.bicep
jbinko Nov 26, 2024
2a090cb
Moving resource group in tests
jbinko Nov 26, 2024
c3e042d
Tags moved to the code to be documented as part of the example
jbinko Nov 26, 2024
02b7450
Removed Lock from the WAF Test Case.
jbinko Nov 26, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
/avm/res/digital-twins/digital-twins-instance/ @Azure/avm-res-digitaltwins-digitaltwinsinstance-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/document-db/database-account/ @Azure/avm-res-documentdb-databaseaccount-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/document-db/mongo-cluster/ @Azure/avm-res-documentdb-mongocluster-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/elastic-san/elastic-san/ @Azure/avm-res-elasticsan-elasticsan-module-owners-bicep @Azure/avm-module-reviewers-bicep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note, the team either does not yet exist, or is not yet approved in the hierachy of teams (ref)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry my bad, I created the groups with prefix "@Azure" => "@Azure/avm-res-elasticsan-elasticsan-module-owners-bicep" and "@Azure/avm-res-elasticsan-elasticsan-module-contributors-bicep". I deleted those teams and created new ones: "avm-res-elasticsan-elasticsan-module-owners-bicep" and "avm-res-elasticsan-elasticsan-module-contributors-bicep".

BTW I'm seeing I was not the only one who did this mistake. I can see more teams with prefix "@Azure" - see: https://github.com/orgs/Azure/teams?query=%40azure

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's actually one more step to it. Once the teams were created, they also have to be placed in the correct hierachy of teams - most notably the reviewer & contributor groups. This will enable your team to approve subsequent PRs for this module.
If correctly requested, one of the PMs should get a noticiation and approve the new child team request in no time :)
cc: @matebarabas

/avm/res/event-grid/domain/ @Azure/avm-res-eventgrid-domain-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/event-grid/namespace/ @Azure/avm-res-eventgrid-namespace-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/event-grid/system-topic/ @Azure/avm-res-eventgrid-systemtopic-module-owners-bicep @Azure/avm-module-reviewers-bicep
Expand Down
1 change: 1 addition & 0 deletions .github/ISSUE_TEMPLATE/avm_module_issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ body:
- "avm/res/digital-twins/digital-twins-instance"
- "avm/res/document-db/database-account"
- "avm/res/document-db/mongo-cluster"
- "avm/res/elastic-san/elastic-san"
- "avm/res/event-grid/domain"
- "avm/res/event-grid/namespace"
- "avm/res/event-grid/system-topic"
Expand Down
88 changes: 88 additions & 0 deletions .github/workflows/avm.res.elastic-san.elastic-san.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
name: "avm.res.elastic-san.elastic-san"

on:
workflow_dispatch:
inputs:
staticValidation:
type: boolean
description: "Execute static validation"
required: false
default: true
deploymentValidation:
type: boolean
description: "Execute deployment validation"
required: false
default: true
removeDeployment:
type: boolean
description: "Remove deployed module"
required: false
default: true
customLocation:
type: string
description: "Default location overwrite (e.g., eastus)"
required: false
push:
branches:
- main
paths:
- ".github/actions/templates/avm-**"
- ".github/workflows/avm.template.module.yml"
- ".github/workflows/avm.res.elastic-san.elastic-san.yml"
- "avm/res/elastic-san/elastic-san/**"
- "avm/utilities/pipelines/**"
- "!avm/utilities/pipelines/platform/**"
- "!*/**/README.md"

env:
modulePath: "avm/res/elastic-san/elastic-san"
workflowPath: ".github/workflows/avm.res.elastic-san.elastic-san.yml"

concurrency:
group: ${{ github.workflow }}

jobs:
###########################
# Initialize pipeline #
###########################
job_initialize_pipeline:
runs-on: ubuntu-latest
name: "Initialize pipeline"
steps:
- name: "Checkout"
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: "Set input parameters to output variables"
id: get-workflow-param
uses: ./.github/actions/templates/avm-getWorkflowInput
with:
workflowPath: "${{ env.workflowPath}}"
- name: "Get module test file paths"
id: get-module-test-file-paths
uses: ./.github/actions/templates/avm-getModuleTestFiles
with:
modulePath: "${{ env.modulePath }}"
outputs:
workflowInput: ${{ steps.get-workflow-param.outputs.workflowInput }}
moduleTestFilePaths: ${{ steps.get-module-test-file-paths.outputs.moduleTestFilePaths }}
psRuleModuleTestFilePaths: ${{ steps.get-module-test-file-paths.outputs.psRuleModuleTestFilePaths }}
modulePath: "${{ env.modulePath }}"

##############################
# Call reusable workflow #
##############################
call-workflow-passing-data:
name: "Run"
permissions:
id-token: write # For OIDC
contents: write # For release tags
needs:
- job_initialize_pipeline
uses: ./.github/workflows/avm.template.module.yml
with:
workflowInput: "${{ needs.job_initialize_pipeline.outputs.workflowInput }}"
moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}"
psRuleModuleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.psRuleModuleTestFilePaths }}"
modulePath: "${{ needs.job_initialize_pipeline.outputs.modulePath}}"
secrets: inherit
Loading