-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new module avm/res/elastic-san/elastic-san #3809
Open
jbinko
wants to merge
162
commits into
Azure:main
Choose a base branch
from
jbinko:avm-res-elastic-san
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11,525
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avm/res/elastic-san/elastic-san/volume-group/snapshot/main.bicep
Outdated
Show resolved
Hide resolved
avm/res/elastic-san/elastic-san/volume-group/snapshot/main.bicep
Outdated
Show resolved
Hide resolved
avm/res/elastic-san/elastic-san/volume-group/snapshot/main.bicep
Outdated
Show resolved
Hide resolved
avm/res/elastic-san/elastic-san/volume-group/snapshot/main.bicep
Outdated
Show resolved
Hide resolved
avm/res/elastic-san/elastic-san/volume-group/snapshot/main.bicep
Outdated
Show resolved
Hide resolved
avm/res/elastic-san/elastic-san/volume-group/snapshot/main.bicep
Outdated
Show resolved
Hide resolved
avm/res/elastic-san/elastic-san/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/elastic-san/elastic-san/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
avm/res/elastic-san/elastic-san/tests/e2e/waf-aligned/main.test.bicep
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
@AlexanderSehr - Thank you for the review. I implemented all proposed changes and tests are passing. Anything else what needs to be changed on my side? Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Needs: Core Team 🧞
This item needs the AVM Core Team to review it
Needs: Triage 🔍
Maintainers need to triage still
Type: AVM 🅰️ ✌️ Ⓜ️
This is an AVM related issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.This is about implementation of the new res module proposed in: #1452. Implementation + Tests + PS Validation tests are included