Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST Review: [ACS Chat] [Private Preview] [Bot Channel V2] [DevEx Internal] #31243

Closed
wants to merge 459 commits into from

Conversation

cheukchuen
Copy link
Member

@cheukchuen cheukchuen commented Oct 25, 2024

New chat message types:

  • azureBotActivity
  • azureBotCommand

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

fix #31697
fix #31697

Copy link

openapi-pipeline-app bot commented Oct 25, 2024

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This is the public specs repo main branch which is not intended for iterative development.
    You must acknowledge that you understand that after this PR is merged, you won't be able to stop your changes from being published to Azure customers.
    If this is what you intend, add PublishToCustomers label to your PR.
    Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR has at least one change violating Azure versioning policy (label: VersioningReviewRequired).
    To unblock this PR, either a) introduce a new API version with these changes instead of modifying an existing API version, or b) follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.

Copy link

openapi-pipeline-app bot commented Oct 25, 2024

Generated ApiView

Language Package Name ApiView Link
Swagger Chat https://apiview.dev/Assemblies/Review/7de49151a2ee45d29d87eee0aa5da23b?revisionId=d1b0449468c246b6ae7e161f7bf4ea83

@AzureRestAPISpecReview AzureRestAPISpecReview added data-plane VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Oct 25, 2024
kazrael2119 and others added 20 commits January 24, 2025 11:50
* add typespec-ts config into tspconfig for mongocluster

* Update tspconfig.yaml

* Update client.tsp

* Update tspconfig.yaml

* Update tspconfig.yaml

---------

Co-authored-by: Qiaoqiao Zhang <[email protected]>
* [mongocluster] Update tspconfig.yaml

* Update tspconfig.yaml

---------

Co-authored-by: Weidong Xu <[email protected]>
* add ts config to standbypool tspconfig

* Update tspconfig.yaml

---------

Co-authored-by: Qiaoqiao Zhang <[email protected]>
…only) fields in OfferDetails (#30334)

* [Astronomer][New Version] Added optional field autoRenew in LiftrBase.OfferDetails

* Added new version in readme file

* Fixing TypeSpec validation issue

* Fixing TypeSpec validation issue

* Fixed TypeSpec Validation issue

* [Fix]: "id" is required to return in response of GET/PUT resource calls

* [Fix]: "id" is required to return in response of GET/PUT resource calls

* Added "endDate" field in OfferDetails

[Updates]
----------------
- Added "endDate" field in OfferDetails
- Defined AutoRenewStatus enum for autoRenew field
- Defined versioning for stable version "2024-08-27"

* Updated AutoRenewStatus enum values type to "string"

* Updated the ordering of AutoRenewStatus enum values

[Update]
----------------
"Enable" is the default value of auto-renew, so placed at first
position.

* Replaced AutoRenewStatus enum by RenewalMode
* added copy of last release

* new devhub changes
removed x-ms-client-flatten
added new routes for ADO OAuth
added azurePipelineProfile obj
* update tspconfig

* update

* fix format
* Adding folders and examples changes for Version 2024-05-01 preview version (#29200)

* Adds base for updating Microsoft.Sql from version preview/2023-08-01-preview to version 2024-05-01-preview

* Updates API version in new specs and examples

* Updates readme

* addressing comments

* resolving spell check errors

* resolving LroLocationheader errors

* supress errors from DatabaseAdvisiors.json

* reverting the supression

---------

Co-authored-by: Ravi Gautam <[email protected]>

* Update for Import/Export with Managed Identity (#29596)

* Update for Import/Export with Managed Identity

* Fix the example reference and update description

* Set the additionalProperties type to string for DatabaseAdvisors API (#29823)

* Set the new additionalProperties type to string

* Remove the required type for additionalProperties, just keep them true

* Dev/ivarandj/instance pool operations api (#29932)

* Add instance pool operations swagger and examples

* Address prettier check errors

* Fix Swagger LintDiff errors

* Fix parameter names to match parameter patterns

* Remove validation for resourceGroupName parameter as it fails Swagger ModelValidation (and it should not be failing)

* Replace bool with enum (PR review remark)

---------

Co-authored-by: Ivan Arandjelovic <[email protected]>

* Adding updated DatabaseOperations.json file (#29956)

* Adding updated DatabaseOperations.json file

* Trying to fix ModelValidation error

* Reverting testing change

---------

Co-authored-by: Roopesh Manda <[email protected]>

* Adding swagger files for minor changes related to release-sql-Microsoft.Sql-2024-05-01-preview (#30030)

* taking changes from dsmaindev side

* removing further DatabaseAdvisor.json changes

* resolving spellcheck validation

* resolving ModelValidation errors

* resolving avocado errors

* resolving LRO Headers Validation and xmsEnum Validation

* resolving indentation

---------

Co-authored-by: Ravi Gautam <[email protected]>

* resolve merge conflict for cSpell.json (#30179)

Co-authored-by: Ravi Gautam <[email protected]>

* reverting cspell.json changes (#30285)

* reverting cspell.json changes

* revert changes2

---------

Co-authored-by: Ravi Gautam <[email protected]>

* Fix lintdiff enum errpr (#30383)

Co-authored-by: Ivan Arandjelovic <[email protected]>

---------

Co-authored-by: Ravi Gautam <[email protected]>
Co-authored-by: psong-ms <[email protected]>
Co-authored-by: UrosKrsticMIPerf <[email protected]>
Co-authored-by: Ivan Arandjelovic <[email protected]>
Co-authored-by: Ivan Arandjelovic <[email protected]>
Co-authored-by: akromm <[email protected]>
Co-authored-by: Roopesh Manda <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
* adding new api stable version folder

* Updating swagger version in swagger and all example files

* adding new api to swagger and creating example, updating readme

* changing the version of common lib

* adding a new property offerId

* prettier-fix

* Create sdk-suppressions.yaml

* update sdk-suppressions.yaml

* Add refresh ingestion key API and its example

* Adding two new props in the response body of getbillinginfo api

---------

Co-authored-by: Shalmoli Neogi <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: kazrael2119 <[email protected]>
Co-authored-by: Dipesh Bhakat <[email protected]>
Co-authored-by: Apoorva Singh <[email protected]>
* base commit

* New api 2024-01-01 version added

* Example file updated

* readme updates

* Create sdk-suppressions.yaml

* Update sdk-suppressions.yaml

---------

Co-authored-by: Your Name <[email protected]>
Co-authored-by: kazrael2119 <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
* [LCM] Update event grid schema to include cold tier stats

* Generated swagger

* Updated storage.json file
…#30537)

* Add Azure Programmable Connecittivity 2024-01-15-preview management API

* Remove deprecated examples-directory config option
* publishing 2024-04-15 api

* added input file details for 2024-04-15

* modified readme for SDK generation error

* removed extra ```

* committing the base version which is 2023-09-01

* Revert "committing the base version which is 2023-09-01"

This reverts commit 421e260.

---------

Co-authored-by: Priya Vijayaraghavan <[email protected]>
rahuls-microsoft and others added 27 commits January 24, 2025 11:53
* Updating the version to "2024-10-01"

* Fix Stable version path in readme.Md

* Updating path for stable version.

* Updating Readme.md files for other languages SDK.

* Updating SDK readme.md files.

* Add Java SDK readme reference to main readme.md file.

* Updating Main.tsp to add GA version.

* Remove version references from individual sdk readme.md files, as it gets it from main.tsp.

* fixing dependencies for2024-10-01 in main.tsp.

* updated generated file from sp.

* Adding example refs back, removed by tool

* Adding examples

* Update main.tsp. local build  - npx tsv specification/azurefleet/AzureFleet.Management

* Update Path for 24_10_01 in main.tsp

* Restore Python package-version: 1.0.0b1

* Adding Retry-after header in 20` response examples.

* Changing API version to 2024-11-01

* Updating  "provisioningState" in example and swagger - adding  "Azure-AsyncOperation" - header.

* update to example.

* Updating the examples based on tsp generated to pass the build. The Tsp files needs to be update for correctness.

* Update examples to have succeeded state

* Update sdk-suppressions.yaml

* Updating examples to add Retry-After header. Update  "provisioningState": "Creating" for 201 responses.

* Changes for Attribute schema.

* Attribute changes.

* Updates.

* Adding Atrributes.

* Supressing - typespec-azure-core/casing-style: The names of Model types must use PascalCase

* Adding VM Attributes properties.

* Adding refrence to VmAttributes and locationProfiles (Needs to be completed for model.)

* Adding AdditionalCapabilities, LocationProfile.

* Run Prettier.

* Spell Check fixes.

* Make paramters optional - vmAttributes, additionalLocationsProfile

* Fixing Descriptions.

* Supress error for ultraSSDEnabled name.

* Updates after npx ci

* Revert "Updates after npx ci"

This reverts commit bf1aed7.

* Updates after npx ci

* Supression  update

* Updating description of ultraSSD to match Compute description.

* Supress Camel Case error for SSD

* Suppress ultraSSDEnabled for DefinitionsPropertiesNamesCamelCase

* Updates based on comments.

* Fix FPGAs. It's listed on - https://learn.microsoft.com/en-us/azure/virtual-machines/sizes/overview?tabs=breakdownseries%2Cgeneralsizelist%2Ccomputesizelist%2Cmemorysizelist%2Cstoragesizelist%2Cgpusizelist%2Cfpgasizelist%2Chpcsizelist#general-purpose

* Updates after npm ci, as the branch was updated from main source.

* Doc updates.

* npx ci, after updatess from main branch.

* Updating VMAttributes as per new spec.

* Updated based on new spec for VMAttributes

* Run npm ci.

* After npm ci.

* remove MaxValue() for float64.

* Updates based on comments.

* updates.

* Updates.

* Fixes for spell Check - localStorageInGiB

* Updates after npm ci.

* Adding memoryInGiBPerVCpu to VMAttributes

* Updates.

* Formatting fixes.

* Updating documrntation for default localStorageSupport=Included.

* Run prettier

---------

Co-authored-by: Sahil Arora <[email protected]>
Co-authored-by: Yuchao Yan <[email protected]>
Co-authored-by: Rahul Singh <[email protected]>
adp spec was removed in #30648 so removing the entry from codeowners.
…#31153)

Bumps the typespec group with 1 update: [@azure-tools/typespec-client-generator-cli](https://github.com/Azure/azure-sdk-tools).


Updates `@azure-tools/typespec-client-generator-cli` from 0.13.1 to 0.13.2
- [Release notes](https://github.com/Azure/azure-sdk-tools/releases)
- [Commits](https://github.com/Azure/azure-sdk-tools/commits)

---
updated-dependencies:
- dependency-name: "@azure-tools/typespec-client-generator-cli"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: typespec
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Move Microsoft.SecretSyncController readme to correct location

* Update swagger path in readme

* Update swagger path in readme
* example starter

* priming

* gen examples

* session xp default

* sessionExpirySeconds in schema

* readme

---------

Co-authored-by: hmmorales <[email protected]>
* Copy files from preview/2024-04-08-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-08-preview

Updated the API version from preview/2024-04-08-preview to preview/2024-08-08-preview.

* Added tag for 2024-08-08-preview in readme file

* update enum descriptions for AppGroupType

* remove deprecated definitions

* update resourceName lengths for top-level objects

* update description, add new read-only property

* shared daysOfWeek enum

* add required properties and patch definitions

* add suppressions for vmTags

* prettier

* prettier for examples

* update suppression to be more specific

* move suppressions file to hopefully work

* update description for registrationToken

* update initiateHPU to return 204 since NoContent
* Add scoped config for Java
…epo (#30792)

* Moving sites swagger files to public repo

* Commiting typespec files

* Removing SiteAware resource type

* Addressing review comments

* Addressing review comment
…interface for java (#31163)

* mgmt, java, workloads, tspconfig, overload service-dir

* rename model for java
* Update version to stable/2024-02-01

Updated the API version from stable/2024-10-01 to stable/2024-02-01.

* Added tag for 2024-02-01 in readme file

* Copy files from stable/2024-02-01

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to stable/2024-10-01

Updated the API version from stable/2024-02-01 to stable/2024-10-01.

* Added tag for 2024-10-01 in readme file

* Add redisenterprise 2024-10-01 version

* Fix prettier checks

* fix prettier issues

* fix lint errors

* fix the clustername pattern

* prettier fix
* Adding base commit for 2023-09-09-preview from 2023-05-01-preview

* Added arc related properties.
Added vcf licensing cost changes.
Added cpuHeadroom property for avs.

* Updated readme to add 2023-09-09-preview.

* Updated examples.

* Fixed oav validate example errors.

* Removing 'typespec-generated' to fix typespec error for now.

* Updated descriptions as per review comments.

* updated readme.

---------

Co-authored-by: Debashish Mohanta <[email protected]>
…31132)

Remove the `tsp.config.yaml` setting `stream-style-serialization: false` from the Java settings to have Document Translation use `azure-json` instead of Jackson for serialization.
* GA changes for text api

* Correct apis in examples

* modelvalidation and avocado errors

* Preview API changes

* Auto ld upgrade

* minor update

* Fix client tsp

* Cleanup and add preview examples

* Edits

* minor fixes

* Recent discussion based changes and cleanup

* more fixes

* Some fixes

* more cleanup

* minor change

* Try modifying entity

* Typo and cleanup

* Add Sharada script

* Discussion based changes and adding summarization example

* Remove redaction character from input parameters

* Add back v2 categories

* Add spell check and try making tags and type optional in NER

* Modify custom text typespec

* cleanup client tsp

* Modify default in cognitive language

* Modify package-dir in tspconfig

* Modify prompt parameter to instruction in abstractive summarization preview api

* cleanup and tspconfig change

---------

Co-authored-by: Aurgho Bhattacharjee <[email protected]>
* Update sdk-suppressions.md

Add more details about the suppression file location for TypeSpec scenarios and OpenAPI scenarios.

* Update documentation/sdkautomation/sdk-suppressions.md

fix typo

Co-authored-by: Mariana Rios Flores <[email protected]>

---------

Co-authored-by: Mariana Rios Flores <[email protected]>
* add directive for cosmosdb

* revert change

* Update readme.typescript.md

---------

Co-authored-by: Qiaoqiao Zhang <[email protected]>
…sting versions (#31184)

* Fix description across versions

* nit fix
#31195)

Bumps the typespec group with 1 update: [@azure-tools/typespec-client-generator-core](https://github.com/Azure/typespec-azure).


Updates `@azure-tools/typespec-client-generator-core` from 0.47.2 to 0.47.3
- [Release notes](https://github.com/Azure/typespec-azure/releases)
- [Commits](https://github.com/Azure/typespec-azure/compare/@azure-tools/[email protected]...@azure-tools/[email protected])

---
updated-dependencies:
- dependency-name: "@azure-tools/typespec-client-generator-core"
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: typespec
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1061)

* Copy files from preview/2024-05-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-07-01-preview

Updated the API version from preview/2024-05-01-preview to preview/2024-07-01-preview.

* Added tag for 2024-07-01-preview in readme file

* update to 2024-07-01-preview

* update regex 360

* update regex s3601

* readme tag
- TSV should automatically check all specs if "core files" changed
- Was only defense-in-depth
- Was not a required check anyway
- Replaces "postinstall" step in each package, with one in tools folder
- Allows one call to `tsc --build` to compile all projects in the correct dependency order
@cheukchuen cheukchuen force-pushed the csiow/acschat-new-message-types branch from dcf3a22 to d69eb3e Compare January 24, 2025 20:00
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@cheukchuen cheukchuen closed this Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-plane PipelineBotTrigger VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IC3 ACS Chat ] API Review