-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IC3 ACS Chat ] API Review #31697
Comments
Azure Versioning policy requires any change to service behavior / API surface be done in a new API version. Please make the proposed changes in a new API version or explain why this is not possible / practical. |
New API Review meeting has been requested. Service Name: IC3 ACS Chat Description: ACS Chat faces several concerns regarding the existing bot channel implementation:
The way we currently implement bot channel integration is not ideal. We're reserving a space in chat message metadata that is meant to be reserved for Contoso's usage, and having json string payload in the message content. We're introducing new message types (AzureBotActivity and AzureBotCommand) in ChatMessageType enum, enabling ACS Chat to act as transport layer so that the entire bot payload can be sent and received by Azure bots in the form of bot activity. Detailed meeting information and documents provided can be accessed here |
Notes from API Review 1/14/25
This mostly looks fine except for concerns about potential to break customers, both in the reformat of the channel data contents and how transitions from passthrough to native are handled. We need to dive deeper on these to make sure we have the best approach. |
Meeting updated by Cheuk Chuen Siow Service Name: IC3 ACS Chat Description: ACS Chat faces several concerns regarding the existing bot channel implementation:
The way we currently implement bot channel integration is not ideal. We're reserving a space in chat message metadata that is meant to be reserved for Contoso's usage, and having json string payload in the message content. We're introducing new message types (AzureBotActivity and AzureBotCommand) in ChatMessageType enum, enabling ACS Chat to act as transport layer so that the entire bot payload can be sent and received by Azure bots in the form of bot activity. Detailed meeting information and documents provided can be accessed here |
Created a new API preview version to introduce a change in the API spec: #32333 |
New API Review meeting has been requested.
Service Name: IC3 ACS Chat
Review Created By: Cheuk Chuen Siow
Review Date: 01/14/2025 01:00 PM PT
Release Plan:
PR: #31243
Hero Scenarios Link: Not Provided
Core Concepts Doc Link: Not Provided
Description: ACS Chat faces several concerns regarding the existing bot channel implementation:
The way we currently implement bot channel integration is not ideal. We're reserving a space in chat message metadata that is meant to be reserved for Contoso's usage, and having json string payload in the message content.
We're introducing new message types (AzureBotActivity and AzureBotCommand) in ChatMessageType enum, enabling ACS Chat to act as transport layer so that the entire bot payload can be sent and received by Azure bots in the form of bot activity.
Detailed meeting information and documents provided can be accessed here
For more information that will help prepare you for this review, the requirements, and office hours, visit the documentation here
The text was updated successfully, but these errors were encountered: