Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E][GB 11.9] Click to add the line-height setting in the tool panel before cheking for its presence #57921

Merged
merged 1 commit into from
Nov 10, 2021
+23 −1
Merged

[E2E][GB 11.9] Click to add the line-height setting in the tool panel before cheking for its presence #57921

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion test/e2e/specs/specs-wpcom/wp-calypso-gutenberg-post-editor-spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,7 @@ describe( `[${ host }] Calypso Gutenberg Editor: Posts (${ screenSize })`, funct
);
} );

it( 'Can see the Line Height setting for the paragraph', async function () {
it( 'Can add and see the Line Height setting for the paragraph in the `Typography` panel', async function () {
const gSidebarComponent = await GutenbergEditorSidebarComponent.Expect( this.driver );

if ( driverManager.currentScreenSize() === 'mobile' )
Expand All @@ -745,6 +745,28 @@ describe( `[${ host }] Calypso Gutenberg Editor: Posts (${ screenSize })`, funct
await gSidebarComponent.displayComponentIfNecessary();
await gSidebarComponent.chooseBlockSettings();

/**
* Before GB 11.9, `line-height` was always shown, but 11.9 introduces changes to the panel that
* requires the user to add some settings manually. Discussion about the rationale can be found
* in this Slack thread:
* - p1636568230296600/1636417237.235700-slack-C7YPUHBB2
*
* This setting is still present for all themes in WPCOM regardless of theme support, so the code
* here still relevant:
*- https://github.com/Automattic/wp-calypso/blob/trunk/apps/editing-toolkit/editing-toolkit-plugin/common/index.php#L179-L182
*
* @todo provided we have more cases like this, abstract this in a `ToolsPanel` general component
* that can handle any `ToolsPanel`-like section that need to have settings added like this.
*/
await driverHelper.clickWhenClickable(
this.driver,
By.css( 'button[aria-label="View and add options"]' )
);
await driverHelper.clickWhenClickable(
this.driver,
By.css( 'button[aria-label="Show Line height"]' )
);

const lineHeighSettingPresent = await driverHelper.isElementLocated(
this.driver,
By.css( '.block-editor-line-height-control' )
Expand Down