[E2E][GB 11.9] Click to add the line-height setting in the tool panel before cheking for its presence
#57921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fullofcaffeine
requested review from
scinos,
WunderBart and
a team
as code owners
matticbot
added
[Status] Needs Review
fullofcaffeine
added
the
caused-by-gutenberg-upgrade
|
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-18996 |
fullofcaffeine
force-pushed
the
fix/line-height-e2e-test
branch
from
0ed62d2 to
c665247
Compare
…ing for its presence
fullofcaffeine
force-pushed
the
fix/line-height-e2e-test
branch
from
c665247 to
4f68116
Compare
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
noahtallen
approved these changes
Nov 10, 2021
I've tested locally, but I'll run from this PR now just in case. Thanks! |
|
The failing tests are not related to the changes. |
github-actions
bot
removed
the
[Status] Needs Review
nelsonec87
pushed a commit
that referenced
this pull request
Dec 9, 2021
…ing for its presence (#57921)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Before Gutenberg 11.9,
line-heightwas always shown in theTypographypanel, but 11.9 introduces changes to the panel thatrequires the user to add some settings manually. Discussion about the rationale can be found in this Slack thread: p1636568230296600/1636417237.235700-slack-C7YPUHBB2.
This setting is still present for all themes in WPCOM regardless of theme support, so the code
here still relevant: https://github.com/Automattic/wp-calypso/blob/trunk/apps/editing-toolkit/editing-toolkit-plugin/common/index.php#L179-L182
Testing instructions
wp-calypso-gutenberg-post-editor-spec.jssuite of tests should pass.Related to: #57451.