Make username configurable #915
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
at least for the WebFinger ID
akirk
reviewed
Oct 1, 2024
Comment on lines
+101
to
+105
| 'key' => 'activitypub_identifier', | ||
| 'value' => $username, | ||
| 'compare' => '=', | ||
| ), | ||
| array( |
There was a problem hiding this comment.
It's probably not worth addressing but it could happen that you assign the identifier to a non-existent user at the time, and then register that username afterwards. In this scenario I believe the result here is undefined since you just pick the first result in the code below.
|
This feels like unnecessary complexity? Can't these users just use the Blog user, which is already configurable, instead? |
|
@mattwiebe the renaming itself is pretty straight forward, but the collision detection is a bit complex. I think I will postpone it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least for the WebFinger ID
Fixes #141 #28 #71
Screenshot: