Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug? Posts by Authors without ActivityPub privilege are not shared by Blog Profile #948

Closed
cdevroe opened this issue Oct 22, 2024 · 12 comments · Fixed by #957
Closed

Bug? Posts by Authors without ActivityPub privilege are not shared by Blog Profile #948

cdevroe opened this issue Oct 22, 2024 · 12 comments · Fixed by #957
Assignees
Labels
Needs triage [Type] Bug Something isn't working

Comments

@cdevroe
Copy link

cdevroe commented Oct 22, 2024

Quick summary

(I'm not sure if this should be considered a bug or if it is working exactly how it is designed.)

My goal is that I have a WordPress Author that I'd prefer not to have an ActivityPub profile, but still want the Blog Profile to share posts by that Author. If I turn Disable ActivityPub for that WordPress Author, but have the Blog Profile turned on in the ActivityPub plugin's settings, the Blog Author does not share/post posts by that WordPress Author.

Steps to reproduce

  1. In the ActivityPub plugin's settings: Enable Author-Profiles
  2. In the ActivityPub plugin's settings: Enable Blog Profile
  3. In Users panel in WordPress Admin, disable ActivityPub for a single user
  4. Publish a post by that user

What you expected to happen

The Blog Profile would still share the post via ActivityPub.

What actually happened

It did not.

Impact

All

Available workarounds?

No but the platform is still usable

Logs or notes

Perhaps the user expectation is that this is working properly. If I disable an Author from ActivityPub, perhaps it is reasonable to conclude I don't want posts authored by the user to be shared at all. So perhaps this would need to be a new setting?

@cdevroe cdevroe added [Type] Bug Something isn't working Needs triage labels Oct 22, 2024
@cdevroe
Copy link
Author

cdevroe commented Oct 22, 2024

Examples:

Browser pub link: https://browser.pub/https://cdevroe.com/@colin

(I currently have the author profile for "cdevroe" disabled for ActivityPub.)

pfefferle added a commit that referenced this issue Oct 25, 2024
Fallback to the blog-user if enabled and the specific user is disabled.

fix #948
@pfefferle
Copy link
Member

@cdevroe one question: Why have you not simply disabled author-profiles completely, if you do not use them?

@cdevroe
Copy link
Author

cdevroe commented Oct 25, 2024

Because I was experimenting with having multiple authors based on some of my side projects.

I think if I could have done anything... I would allow me to rename my author's profile name. So, many moons ago I setup my WordPress Author as "cdevroe". But I don't want my ActivityPub profile to be @[email protected] -- but there is no way to specify that I'd prefer to use "colin". If I was able to do that, I wouldn't need a blog profile at all.

@pfefferle
Copy link
Member

But the question is still: why don't you simply disable all author profiles?

@cdevroe
Copy link
Author

cdevroe commented Oct 25, 2024

I will do so and just forgo the desire to have multiple profiles powered by my blog. Thank you!

@pfefferle
Copy link
Member

pfefferle commented Oct 25, 2024

Oh no, you don't have to, the PR will fix your issue and you can keep your settings as they are!!!

This questions are not meant to force you to change something, I simply want to understand the needs of every user, to improve the plugin and to maybe rework some things!

@cdevroe
Copy link
Author

cdevroe commented Oct 25, 2024

OK Matthias! 😄

So, I could eventually see having as many as 3 profiles powered by my blog. So, that is why I hadn't disabled all author profiles. Does that make sense?

@pfefferle
Copy link
Member

pfefferle commented Oct 25, 2024

Totally! ... and I know at least one other blog owner who is interested in that feature!

Sorry if my question was a bit misleading!

@cdevroe
Copy link
Author

cdevroe commented Oct 25, 2024

No worries! For now, I'll turn profiles off and just keep the blog profile so that posts are shared through that. Perhaps my specific case cannot be fixed since I have a username I wish I didn't. That is totally fine.

@pfefferle
Copy link
Member

@cdevroe #915 :)

@cdevroe
Copy link
Author

cdevroe commented Oct 28, 2024

I see that PR is paused. Which totally makes sense. Thank you for even taking the time to look at it!

@pfefferle
Copy link
Member

yes, it is a bit complex and we might need the Move functionality first!

pfefferle added a commit that referenced this issue Oct 31, 2024
* Fallback to blog-user if user is disabled

Fallback to the blog-user if enabled and the specific user is disabled.

fix #948

* add test case

* test-class-activitypub-activity-dispatcher.php aktualisieren

Co-authored-by: Konstantin Obenland <[email protected]>

---------

Co-authored-by: Konstantin Obenland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants