Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the version check regex to allow major versions > 9 #7352

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Fixed the version check regex to allow major versions > 9 #7352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c1d47d9
Fixed the version check regex to allow major versions > 9
leonardola Oct 3, 2023
f0917aa
Add changelog
leonardola Oct 3, 2023
ad04862
Fixed the changelog
leonardola Oct 10, 2023
51f4640
Fixed regex to allow xx.x.xx versions
leonardola Oct 10, 2023
427a205
readded changelog
leonardola Oct 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/actions/version-check/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ runs:
TRIMMED_VERSION=$(echo "$VERSION" | xargs)

if ${{ env.IS_PRERELEASE == 'true' }}; then
VERSION_FORMAT="^[0-9]\.[0-9]\.[0-9]-test-[1-9]$"
VERSION_FORMAT="^[0-9]+\.[0-9]\.[0-9]+-test-[1-9]$"
else
VERSION_FORMAT="^[0-9]\.[0-9]\.[0-9]$"
VERSION_FORMAT="^[0-9]+\.[0-9]\.[0-9]+$"
fi

if [[ $TRIMMED_VERSION =~ $VERSION_FORMAT ]]; then
Expand Down
4 changes: 4 additions & 0 deletions changelog/fix-major-version-check
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: dev

Fixed version check regex
Copy link
Contributor

@jbordonado jbordonado Oct 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed it's not an insignificant changelog, and it will appear in the next release's changelog if it stays like that.

Could you redo it so it's marked as a "comment"? It should, in the end, be written as:

Comment: Fixed version check regex

It's just a matter of leaving the first question empty after selecting "patch" I think (you'll see a text mentioning "insignificant", "leave empty" ...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with ad04862