Fixed the version check regex to allow major versions > 9 #7352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardola
requested review from
a team and
hsingyuc
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
jbordonado
approved these changes
Oct 9, 2023
jbordonado
suggested changes
Oct 9, 2023
| Significance: patch | ||
| Type: fix | ||
|
|
||
| Fixed version check regex |
There was a problem hiding this comment.
Just noticed it's not an insignificant changelog, and it will appear in the next release's changelog if it stays like that.
Could you redo it so it's marked as a "comment"? It should, in the end, be written as:
Comment: Fixed version check regex
It's just a matter of leaving the first question empty after selecting "patch" I think (you'll see a text mentioning "insignificant", "leave empty" ...)
There was a problem hiding this comment.
Fixed with ad04862
hsingyuc
reviewed
Oct 10, 2023
There was a problem hiding this comment.
@leonardola Thank you for working on this! I left two comments below.
| @@ -29,9 +29,9 @@ runs: | |||
| TRIMMED_VERSION=$(echo "$VERSION" | xargs) | |||
|
|
|||
| if ${{ env.IS_PRERELEASE == 'true' }}; then | |||
| VERSION_FORMAT="^[0-9]\.[0-9]\.[0-9]-test-[1-9]$" | |||
| VERSION_FORMAT="^[0-9]+\.[0-9]\.[0-9]-test-[1-9]$" | |||
There was a problem hiding this comment.
Assuming we won't add the test version more than 3, besides that last one, we might want to add + after each of the [0-9], or it could break with the number over 9. For example, 10.10.10-test-1
There was a problem hiding this comment.
Sorry, I didn't notice Jordan's comment.
There was a problem hiding this comment.
I don't think x.10.z would ever happen given the way we follow the versioning in Transact, but x.y.10 can happen yes
There was a problem hiding this comment.
Fixed with 51f4640
| else | ||
| VERSION_FORMAT="^[0-9]\.[0-9]\.[0-9]$" | ||
| VERSION_FORMAT="^[0-9]+\.[0-9]\.[0-9]$" |
There was a problem hiding this comment.
Fixed with 51f4640
leonardola
force-pushed
the
fix/major-version-check
branch
from
303b364 to
51f4640
Compare
hsingyuc
approved these changes
Oct 11, 2023
jbordonado
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5706
Changes proposed in this Pull Request
This PR fixes the Regex used to check the release version to allow major versions > 9
Testing instructions
The easiest way is to simply check the regexes match given versions.
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge