-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate format option on slowlogs command #1785
Merged
maxschmeling
merged 11 commits into
trunk
from
fix/BB8-11235-format-option-confusion-on-slowlogs
Apr 22, 2024
Merged
Fix duplicate format option on slowlogs command #1785
maxschmeling
merged 11 commits into
trunk
from
fix/BB8-11235-format-option-confusion-on-slowlogs
Apr 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
This reverts commit 2a30b67.
Tested locally, and your updates are huge improvements! 🎉 |
7 tasks
Quality Gate passedIssues Measures |
luiztiago
approved these changes
Apr 22, 2024
maxschmeling
deleted the
fix/BB8-11235-format-option-confusion-on-slowlogs
branch
April 22, 2024 20:10
maxschmeling
added a commit
that referenced
this pull request
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
slowlogs
command currently prints two--format
options:and this is because the
format: true
option is provided in that commands setup while also providing a "custom"format
option. It also showstext
as a default when that's not a valid option at all.Changelog Description
Updated the "logs" and "slowlogs" commands to use the "table" output format by default, rather than the non-existent "text" format. This makes the help text for these commands less confusing, and makes them more consistent with the rest of the CLI.
Pull request checklist
New release checklist
Steps to Test
Outline the steps to test and verify the PR here.
Example:
npm run build
node ./dist/bin/vip-slowlogs.js @{app}.{env} --help