Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the slowlogs command to follow the VIP-CLI styleguide #1782

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

terriann
Copy link
Contributor

Description

Updated the voice, tense, and format of command descriptions, examples, and usage models for the vip slowlogs command to follow the VIP-CLI style guide.

Pull request checklist

New release checklist

Steps to Test

Observe the results of the --help display for impacted commands:

  • vip slowlogs

@terriann terriann requested a review from yolih April 16, 2024 19:57
Copy link
Contributor

github-actions bot commented Apr 16, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

src/bin/vip-slowlogs.ts Outdated Show resolved Hide resolved
src/bin/vip-slowlogs.ts Outdated Show resolved Hide resolved
@terriann terriann added the [Type] Documentation Pull request to update documentation. label Apr 17, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@terriann
Copy link
Contributor Author

Let's keep this in a holding pattern till #1785 is merged - just in case we want to adjust any language 🙂

@rebeccahum
Copy link
Contributor

@terriann Some merge conflicts need to be resolved

@sjinks sjinks force-pushed the update/docs-pt-vip-slowlogs branch from b000511 to 33ae90f Compare June 6, 2024 05:19
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rebeccahum rebeccahum merged commit 7ece0f0 into trunk Jun 6, 2024
16 checks passed
@rebeccahum rebeccahum deleted the update/docs-pt-vip-slowlogs branch June 6, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Documentation Pull request to update documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants